fix(@angular/ssr): check whether injector is destroyed #30738
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we check whether the injector is destroyed before calling to `envInjector.get`. The application might be destroyed and `whenStable()` would resolve immediately; as thus, calling to `injector.get` is unsafe and should be guarded.
clydin
added
the
action: review
alan-agius4
reviewed
Jul 18, 2025
| const routerIsProvided = !!envInjector.get(ActivatedRoute, null); | ||
| const router = envInjector.get(Router); | ||
| const lastSuccessfulNavigation = router.lastSuccessfulNavigation; | ||
| const routerIsProvided = destroyed ? false : !!envInjector.get(ActivatedRoute, null); |
There was a problem hiding this comment.
What is the case when the applicationRef gets destroyed before the rendering phase? Internally in
the environment injector is also required to render the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we check whether the injector is destroyed before calling to
envInjector.get. The application might be destroyed andwhenStable()would resolve immediately; as thus, calling toinjector.getis unsafe and should be guarded.