fix: file already exists #297
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngruelaneo
approved these changes
Mar 12, 2025
ngruelaneo
previously approved these changes
Mar 12, 2025
dbrasseur-aneo
force-pushed
the
db/fix_move_s3
branch
from
1eb6346 to
8c24c68
Compare
aneojgurhem
reviewed
Mar 12, 2025
aneojgurhem
reviewed
Mar 12, 2025
Comment on lines
+124
to
+127
| catch (IOException ioException) | ||
| { | ||
| // File already exists | ||
| } |
Contributor
There was a problem hiding this comment.
Is there something finer than that ? It looks a bit wide to me
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
yes but this can be raised in other cases too. https://learn.microsoft.com/en-us/dotnet/api/system.io.ioexception?view=net-9.0#remarks
dbrasseur-aneo
force-pushed
the
db/fix_move_s3
branch
from
8c24c68 to
2d78204
Compare
Contributor
Author
|
Shall we cherry-pick d5aeb15 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.