Skip to content

Commit 0530daf

Browse files
committed
[push] minor fixes
1 parent 77f7529 commit 0530daf

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

internal/sms-gateway/modules/push/service.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ func New(
7070
}, nil
7171
}
7272

73-
// Run runs the service with the provided context if a debounce is set.
73+
// Run starts a ticker that triggers the sendAll function every debounce interval.
74+
// It runs indefinitely until the provided context is canceled.
7475
func (s *Service) Run(ctx context.Context) {
7576
ticker := time.NewTicker(s.config.Debounce)
7677
defer ticker.Stop()
@@ -103,10 +104,12 @@ func (s *Service) Enqueue(token string, event types.Event) error {
103104
}
104105
wrapperData, err := wrapper.serialize()
105106
if err != nil {
107+
s.metrics.IncError(1)
106108
return fmt.Errorf("can't serialize event wrapper: %w", err)
107109
}
108110

109111
if err := s.events.Set(ctx, wrapper.key(), wrapperData); err != nil {
112+
s.metrics.IncError(1)
110113
return fmt.Errorf("can't add message to cache: %w", err)
111114
}
112115

@@ -189,12 +192,13 @@ func (s *Service) sendAll(ctx context.Context) {
189192
wrapperData, err := wrapper.serialize()
190193
if err != nil {
191194
s.metrics.IncError(1)
192-
s.logger.Info("Can't serialize event wrapper", zap.Error(err))
195+
s.logger.Error("Can't serialize event wrapper", zap.Error(err))
193196
continue
194197
}
195198

196199
if setErr := s.events.SetOrFail(ctx, wrapper.key(), wrapperData); setErr != nil {
197-
s.logger.Info("Can't set message to cache", zap.Error(setErr))
200+
s.logger.Warn("Can't set message to cache", zap.Error(setErr))
201+
continue
198202
}
199203

200204
s.metrics.IncRetry(RetryOutcomeRetried)

0 commit comments

Comments
 (0)