Skip some tests with check-envtest-existing

Tests for reconciling resources that require a postgrescluster object as
an owner are failing due to the garbage collector. The collector will
delete these resource before the test completes when the owner does not
exist. Until we find a better solution for running these tests without
creating the owning object, we are skipping them when running against a
live cluster.

Author: jmckulk

internal/controller/postgrescluster/patroni_test.go

@@ -20,6 +20,7 @@ package postgrescluster
 import (
 	"context"
 	"fmt"
+	"os"
 	"strconv"
 	"strings"
 	"testing"
@@ -41,6 +42,11 @@ import (
 )
 
 func TestPatroniReplicationSecret(t *testing.T) {
+	// Garbage collector cleans up test resources before the test completes
+	if strings.EqualFold(os.Getenv("USE_EXISTING_CLUSTER"), "true") {
+		t.Skip("USE_EXISTING_CLUSTER: Test fails due to garbage collection")
+	}
+
 	// setup the test environment and ensure a clean teardown
 	tEnv, tClient, cfg := setupTestEnv(t, ControllerName)
 	t.Cleanup(func() { teardownTestEnv(t, tEnv) })

internal/controller/postgrescluster/pgbackrest_test.go

@@ -22,7 +22,9 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"os"
 	"strconv"
+	"strings"
 	"testing"
 	"time"
 
@@ -121,6 +123,10 @@ func fakePostgresCluster(clusterName, namespace, clusterUID string,
 }
 
 func TestReconcilePGBackRest(t *testing.T) {
+	// Garbage collector cleans up test resources before the test completes
+	if strings.EqualFold(os.Getenv("USE_EXISTING_CLUSTER"), "true") {
+		t.Skip("USE_EXISTING_CLUSTER: Test fails due to garbage collection")
+	}
 
 	// setup the test environment and ensure a clean teardown
 	tEnv, tClient, cfg := setupTestEnv(t, ControllerName)
@@ -434,6 +440,10 @@ func TestReconcilePGBackRest(t *testing.T) {
 }
 
 func TestReconcilePGBackRestRBAC(t *testing.T) {
+	// Garbage collector cleans up test resources before the test completes
+	if strings.EqualFold(os.Getenv("USE_EXISTING_CLUSTER"), "true") {
+		t.Skip("USE_EXISTING_CLUSTER: Test fails due to garbage collection")
+	}
 
 	// setup the test environment and ensure a clean teardown
 	tEnv, tClient, cfg := setupTestEnv(t, ControllerName)
@@ -1332,6 +1342,10 @@ func TestReconcileManualBackup(t *testing.T) {
 }
 
 func TestGetPGBackRestResources(t *testing.T) {
+	// Garbage collector cleans up test resources before the test completes
+	if strings.EqualFold(os.Getenv("USE_EXISTING_CLUSTER"), "true") {
+		t.Skip("USE_EXISTING_CLUSTER: Test fails due to garbage collection")
+	}
 
 	// setup the test environment and ensure a clean teardown
 	tEnv, tClient, cfg := setupTestEnv(t, ControllerName)

internal/controller/postgrescluster/pki_test.go

@@ -43,6 +43,11 @@ import (
 )
 
 func TestReconcileCerts(t *testing.T) {
+	// Garbage collector cleans up test resources before the test completes
+	if strings.EqualFold(os.Getenv("USE_EXISTING_CLUSTER"), "true") {
+		t.Skip("USE_EXISTING_CLUSTER: Test fails due to garbage collection")
+	}
+
 	// setup the test environment and ensure a clean teardown
 	tEnv, tClient, _ := setupTestEnv(t, ControllerName)
 	ctx := context.Background()