Skip to content

Commit 86a13e5

Browse files
committed
add name and lang in title for safari print file name - adjust footer content
1 parent 241e5af commit 86a13e5

5 files changed

Lines changed: 30 additions & 11 deletions

File tree

src/main/resources/messages_de.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"nbsps-before-footer": ["8","5"],
23
"working_experience_page1_drop_take": ["3","1"],
34
"born_label": ["Born"],
45
"citizenship_label": ["Bürgerschaft"],

src/main/resources/messages_en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"nbsps-before-footer": ["4","2"],
23
"working_experience_page1_drop_take": ["3","1"],
34
"born_label": ["Born"],
45
"citizenship_label": ["Citizenship"],

src/main/scala/dk/bohnjespersen/anders/resume/MainApp.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ object MainApp extends ZIOAppDefault {
4646
for {
4747
messages <- gistJson.messages(lang)
4848
resume <- gistJson.resume(lang, patch)
49-
ht = ResumeHtml.resume(using resume, messages, deko)
49+
ht = ResumeHtml.resume(lang, aspect)(using resume, messages, deko)
5050
} yield Response.html(ht),
5151
)
5252
.tapError(e => Console.printLine(s"Failed to serve resource $lang $deko $aspect : $e"))

src/main/scala/dk/bohnjespersen/anders/resume/service/ResumeHtml.scala

Lines changed: 26 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import zio.*
88
import zio.http.*
99
import zio.http.template.{footer, *}
1010

11+
import dk.bohnjespersen.anders.resume.domain.types.{Aspect, Lang}
1112
import dk.bohnjespersen.anders.resume.service.Messages
1213

1314
object ResumeHtml {
@@ -109,14 +110,16 @@ object ResumeHtml {
109110
def makeFooter(
110111
gitRef: String,
111112
extraDivClass: Option[String] = None,
113+
extraPs: Int = 0,
112114
): Dom = div(
113-
classAttr := s"row ${extraDivClass.mkString}",
115+
classAttr := s"row print-footer ${extraDivClass.mkString}",
114116
div(
115117
classAttr := "span4",
116118
Nbsp,
117119
),
118120
div(
119121
classAttr := "span4",
122+
(1 to extraPs).map(_ => p(Nbsp)),
120123
footer(
121124
i(s"$gitRef", classAttr := "version-tag"),
122125
),
@@ -200,15 +203,29 @@ object ResumeHtml {
200203
body(content),
201204
)
202205

203-
def resume(implicit resume: Resume, messages: Messages, deko: Boolean): Html = {
204-
val gitRef = sys
206+
private def jsonPairInts(key: String)(implicit
207+
resume: Resume,
208+
messages: Messages,
209+
): (Int, Int) = {
210+
val lst = messages
211+
.mfks(key)
212+
.map(_.toInt)
213+
lst(0) -> lst(1)
214+
}
215+
216+
def resume(lang: Lang, aspect: Aspect)(implicit
217+
resume: Resume,
218+
messages: Messages,
219+
deko: Boolean,
220+
): Html = {
221+
val gitRef = sys
205222
.env
206223
.get("GITHUB_REF_NAME")
207224
.orElse(sys.env.get("GITHUB_SHA").map(_.take(7)))
208225
.getOrElse("local-dev " + ZonedDateTime.now(ZoneId.of("Zulu")).format(dateTimeFormatter))
209-
val weDropTake = messages.mfks("working_experience_page1_drop_take").map(_.toInt)
210-
val (dropCount, takeCnt) = weDropTake(0) -> weDropTake(1)
211-
val personalAsInterests = List(
226+
val (extraNbspPage1, extraNbspPage2) = jsonPairInts("nbsps-before-footer")
227+
val (dropCount, takeCnt) = jsonPairInts("working_experience_page1_drop_take")
228+
val personalAsInterests = List(
212229
Interest(
213230
messages.mfk("skills_label"),
214231
messages.mfks("skills_list"),
@@ -223,7 +240,7 @@ object ResumeHtml {
223240
),
224241
)
225242
main(
226-
"Resume Anders Bohn Jespersen",
243+
s"CV - $aspect - $lang - Anders Bohn Jespersen - $gitRef",
227244
div(
228245
classAttr := "wrap",
229246
div(
@@ -237,7 +254,7 @@ object ResumeHtml {
237254
),
238255
),
239256
cvItems(personalAsInterests ::: resume.interests, "interests_heading"),
240-
makeFooter(gitRef, Some("hide-on-phone")),
257+
makeFooter(gitRef, Some("hide-on-phone"), extraNbspPage1),
241258
),
242259
),
243260
div(
@@ -246,7 +263,7 @@ object ResumeHtml {
246263
classAttr := "content",
247264
header(Some("hide-on-phone")),
248265
cvItems(resume.work.dropRight(dropCount), "working_experience_heading"),
249-
makeFooter(gitRef, Some("hide-on-phone")),
266+
makeFooter(gitRef, Some("hide-on-phone"), extraNbspPage2),
250267
),
251268
),
252269
)

src/main/scala/dk/bohnjespersen/anders/resume/util/StaticExporter.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ object StaticExporter extends ZIOAppDefault {
4444
messages <- gistJson.messages(lang)
4545
patch = MainApp.aspectOrLangPatch(None, aspect, lang)
4646
resume <- gistJson.resume(lang, patch)
47-
ht = ResumeHtml.resume(using resume, messages, false)
47+
ht = ResumeHtml.resume(lang, aspect)(using resume, messages, false)
4848
} yield Response.html(ht),
4949
)
5050

0 commit comments

Comments
 (0)