Fix null pointer dereference in ad9361_rfpll_vco_init

Xenoamor · Joshua Booth · commit beb9ccab9c51 · 2025-10-06T14:23:44.000+01:00
Signed-off-by: Joshua Booth &lt;joshua@icoteq.com&gt;
diff --git a/drivers/rf-transceiver/ad9361/ad9361.c b/drivers/rf-transceiver/ad9361/ad9361.c
@@ -1746,7 +1746,7 @@ static int32_t ad9361_rfpll_vco_init(struct ad9361_rf_phy *phy,
 				     uint32_t ref_clk)
 {
 	struct no_os_spi_desc *spi = phy->spi;
-	const struct SynthLUT(*tab);
+	const struct SynthLUT(*tab) = NULL;
 	int32_t i = 0;
 	uint32_t range, offs = 0;
 
@@ -1775,6 +1775,12 @@ static int32_t ad9361_rfpll_vco_init(struct ad9361_rf_phy *phy,
 		}
 	}
 
+	if (tab == NULL) {
+		dev_err(&phy->spi->dev,
+			"%s: Failed to find suitable SynthLUT table", __func__);
+		return -EINVAL;
+	}
+
 	if (tx)
 		offs = REG_TX_VCO_OUTPUT - REG_RX_VCO_OUTPUT;
 

Original file line number	Diff line number	Diff line change
`@@ -1746,7 +1746,7 @@ static int32_t ad9361_rfpll_vco_init(struct ad9361_rf_phy *phy,`
`1746`	`1746`	`uint32_t ref_clk)`
`1747`	`1747`	`{`
`1748`	`1748`	`struct no_os_spi_desc *spi = phy->spi;`
`1749`		`- const struct SynthLUT(*tab);`
	`1749`	`+ const struct SynthLUT(*tab) = NULL;`
`1750`	`1750`	`int32_t i = 0;`
`1751`	`1751`	`uint32_t range, offs = 0;`
`1752`	`1752`
`@@ -1775,6 +1775,12 @@ static int32_t ad9361_rfpll_vco_init(struct ad9361_rf_phy *phy,`
`1775`	`1775`	`}`
`1776`	`1776`	`}`
`1777`	`1777`
	`1778`	`+ if (tab == NULL) {`
	`1779`	`+ dev_err(&phy->spi->dev,`
	`1780`	`+ "%s: Failed to find suitable SynthLUT table", __func__);`
	`1781`	`+ return -EINVAL;`
	`1782`	`+ }`
	`1783`	`+`
`1778`	`1784`	`if (tx)`
`1779`	`1785`	`offs = REG_TX_VCO_OUTPUT - REG_RX_VCO_OUTPUT;`
`1780`	`1786`