Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text alignment is not vertically centered in MacOS, Linux #616

Open
rocksdanister opened this issue Oct 13, 2024 · 4 comments · May be fixed by #626
Open

Text alignment is not vertically centered in MacOS, Linux #616

rocksdanister opened this issue Oct 13, 2024 · 4 comments · May be fixed by #626
Labels
bug Something isn't working

Comments

@rocksdanister
Copy link

Describe the bug
The text alignment is not vertically centered in some controls like ComboBox.
The margin between Header and Description in Expander is also a bit short.

Screenshots
image
MacOS

image
Linux

image
Windows 11 for comparison

Desktop/Platform (please complete the following information):

  • OS: MacOS Sequoia, Fedora
  • FluentAvalonia Version: 2.1.0
  • Avalonia Version: 11.2.0-rc1

Additional context
Looks like it should be fixed by #128, TextVerticalAlignmentOverride is not set(default.)
@rocksdanister rocksdanister added the bug Something isn't working label Oct 13, 2024
@rocksdanister rocksdanister mentioned this issue Oct 13, 2024
Merged
61 tasks
@amwx
Copy link
Owner

amwx commented Nov 29, 2024

https://amwx.github.io/FluentAvaloniaDocs/pages/FATheme/Misc

@amwx amwx closed this as completed Nov 29, 2024
@rocksdanister
Copy link
Author

Maybe I am reading the docs wrong.. I did not set TextVerticalAlignmentOverride which means EnabledNonWindows (default) the fix should be enabled right?

@amwx
Copy link
Owner

amwx commented Dec 1, 2024

Ok, so this is actually a larger bug with how FATheme initializes, which was likely introduced when it was converted to a xaml file to accommodate AOT - so its been a while. Investigating a fix...

@amwx amwx reopened this Dec 1, 2024
@amwx amwx linked a pull request Dec 1, 2024 that will close this issue
Open
@rocksdanister
Copy link
Author

I am not sure about that, text appears to be aligned correctly on Ubuntu distro.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix VerticalTextAlignment Override not being set when initializing amwx/FluentAvalonia
2 participants
@rocksdanister @amwx