Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable lightbox toggle for image linking to attachment pages #3579

Closed
swissspidy opened this issue Oct 21, 2019 · 5 comments
Closed

Disable lightbox toggle for image linking to attachment pages #3579

swissspidy opened this issue Oct 21, 2019 · 5 comments
Labels
Editor Enhancement New feature or improvement of an existing one Groomed Integration: Gutenberg P2 Low priority WS:Core Work stream for Plugin core

Comments

@swissspidy
Copy link
Collaborator

Feature description

This is a follow-up to #3450. As proposed in #3460 (review), "the lightbox toggle should probably be prevented from even being made available when the image block has a link to the attachment page. Otherwise, the lightbox toggle has no effect when an attachment page is linked."


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter
Copy link
Member

@jamesozzie pointed out that images in AMP pages now automatically get lightboxing. See https://github.com/ampproject/amphtml/blob/master/spec/auto-lightbox.md

Do we even need the lightbox toggle anymore?

@westonruter westonruter added the P2 Low priority label Nov 26, 2019
@amedina
Copy link
Member

amedina commented Apr 1, 2020

Do we even need the lightbox toggle anymore?

Closing (as per comment above) and will reopen if needed.

@amedina amedina closed this as completed Apr 1, 2020
@westonruter
Copy link
Member

Let's leave open because we should remove the toggle if indeed it is unnecessary.

@westonruter
Copy link
Member

Closely related issue: #4591

@kmyram kmyram added the WS:Core Work stream for Plugin core label Aug 5, 2020
@kmyram kmyram added the Groomed label Nov 24, 2020
@kmyram kmyram added this to the v2.1 milestone Nov 24, 2020
@westonruter westonruter removed this from the v2.1 milestone Dec 10, 2020
@westonruter
Copy link
Member

Attachment pages are disabled in 6.4. Also, in 6.4 lightbox images are now supported in core. So in #7676 we're going to eliminate the AMP toggle when on 6.4. Otherwise, it doesn't seem necessary to anything further with this issue.

@westonruter westonruter closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Ongoing Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Enhancement New feature or improvement of an existing one Groomed Integration: Gutenberg P2 Low priority WS:Core Work stream for Plugin core
Projects
Archived in project
Development

No branches or pull requests

4 participants