Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility check issue: eslint-plugin-compat is checking against node 14.x instead of just node 16.x after upgrading to latest version 4.1.4 #567

Open
makstaks opened this issue Apr 12, 2023 · 4 comments

Comments

@makstaks
Copy link

makstaks commented Apr 12, 2023

After upgrading to the latest version 4.1.4 of eslint-plugin-compat from 4.1.2, the plugin is checking compatibility against node 14.x instead of just node 16.x (my node runtime version). I wasn't able to gather from the docs if there exists a configuration setting to specify the node version range.

Environment:
Node Runtime: v16.15.0
OS: Windows 11 Enterprise

@koddsson
Copy link
Contributor

After upgrading to the latest version 4.1.4 of eslint-plugin-compat from 4.1.2, the plugin is checking compatibility against node 14.x instead of just node 16.x (my node runtime version).

Hey! I'm unsure how this issue manifests for you. Do you have a small reproduction that we can check out?

I think this issue is due to #565 but I'd like to understand the problem better so we can fix it correctly :)

@ppJuan
Copy link

ppJuan commented Sep 20, 2024

After upgrading to the latest version 4.1.4 of eslint-plugin-compat from 4.1.2, the plugin is checking compatibility against node 14.x instead of just node 16.x (my node runtime version).

Hey! I'm unsure how this issue manifests for you. Do you have a small reproduction that we can check out?

I think this issue is due to #565 but I'd like to understand the problem better so we can fix it correctly :)

@koddsson
Hello, now installing [email protected] needs node18, is there any way to use it in node14?

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.x". Got "14.17.2"

@koddsson
Copy link
Contributor

koddsson commented Oct 8, 2024

After upgrading to the latest version 4.1.4 of eslint-plugin-compat from 4.1.2, the plugin is checking compatibility against node 14.x instead of just node 16.x (my node runtime version).

Hey! I'm unsure how this issue manifests for you. Do you have a small reproduction that we can check out?
I think this issue is due to #565 but I'd like to understand the problem better so we can fix it correctly :)

@koddsson Hello, now installing [email protected] needs node18, is there any way to use it in node14?

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.x". Got "14.17.2"

Hey! I'm not a maintainer of this library so I can't tell you for sure but I don't think this library supports node 14 anymore.

I'd suggest putting some work in upgrading to at least node 18 as previous node versions are no longer supported. Node 18 is a LTS (Long Term Support) release which means that it will receive critical bug fixes until June 2025.

(Libraries can still decide to not support older versions of course but being on a LTS version of node means that you at least will receive critical bug fixes)

See more here: https://nodejs.org/en/about/previous-releases

@ppJuan
Copy link

ppJuan commented Oct 8, 2024

After upgrading to the latest version 4.1.4 of eslint-plugin-compat from 4.1.2, the plugin is checking compatibility against node 14.x instead of just node 16.x (my node runtime version).

Hey! I'm unsure how this issue manifests for you. Do you have a small reproduction that we can check out?
I think this issue is due to #565 but I'd like to understand the problem better so we can fix it correctly :)

@koddsson Hello, now installing [email protected] needs node18, is there any way to use it in node14?
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.x". Got "14.17.2"

Hey! I'm not a maintainer of this library so I can't tell you for sure but I don't think this library supports node 14 anymore.

I'd suggest putting some work in upgrading to at least node 18 as previous node versions are no longer supported. Node 18 is a LTS (Long Term Support) release which means that it will receive critical bug fixes until June 2025.

(Libraries can still decide to not support older versions of course but being on a LTS version of node means that you at least will receive critical bug fixes)

See more here: https://nodejs.org/en/about/previous-releases

@koddsson thanks for replying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants