Repository navigation
serving-llms-on-instinct: fix Docker check, apply model_overrides, check free VRAM - #284
Open
sabira-shaik wants to merge 1 commit into
Open
sabira-shaik wants to merge 1 commit into
sabira-shaik wants to merge 1 commit into
Conversation
…eck free VRAM - validate.py: `docker ps -q 2>&1 | head -1` always exits 0 (head's exit code) and hides stderr, so a broken Docker setup was reported as ready. Run plain `docker ps -q`. - SKILL.md: Step 4 never read `gpu_configs.<gfx>.model_overrides`, so the gfx950 gpt-oss override (VLLM_ROCM_USE_AITER_MOE=0) was never applied. - estimate_vram.py: the fit check assumed the whole GPU was free. Read free VRAM from amd-smi (or --free-vram-gb), cap gpu_memory_utilization to it, and report can_serve. SKILL.md stops before launch when can_serve is false.
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes to
serving-llms-on-instinct, found while testing the skill on an MI300X.1. Docker check never fails (
scripts/validate.py)docker ps -q 2>&1 | head -1returnshead's exit code (always 0), and2>&1moves Docker's error into stdout, sovalidate.pyreportedready: truewith Docker unreachable. It now runs plaindocker ps -q.2. gfx950 gpt-oss override never applied (
SKILL.md)data/gpu_overrides.jsonsetsVLLM_ROCM_USE_AITER_MOE=0foropenai/gpt-osson gfx950 (the AITER MoE path corrupts its output), butSKILL.mdnever mentionsmodel_overrides, so the agent never applies it. Step 4 now mergesmodel_overrides[].env_setwhen the model ID matches.3. Fit check ignores memory already in use (
scripts/estimate_vram.py,SKILL.md)The fit check assumed the whole GPU was free. vLLM's
--gpu-memory-utilizationis a fraction of total VRAM and vLLM refuses to start if that much is not free, so with another vLLM container running, the skill said a model fits and the launch failed. This also makes two models on one GPU a trial-and-error loop.estimate_vram.pynow reads free VRAM fromamd-smi metric --mem-usage(or--free-vram-gbfor remote hosts), capsgpu_memory_utilizationto what is free (2 GB margin), and reportsfree_vram_gb,min_needed_gb(weights + 4 GB overhead + 2 GB KV) andcan_serve.SKILL.mdstops before launch whencan_serveis false and otherwise uses the computed utilization.MI300X, with another vLLM container (Qwen3.5-9B at util 0.9) holding 175 GB:
can_serve: true, util 0.09can_serve: false(needs 18.8 GB)can_serve: false(needs 67 GB)--free-vram-gb 191.7can_serve: true, util 0.9 (unchanged)Testing
estimate_vram.pyon an MI300X (ROCm 7.2) for the cases in the table../.github/scripts/check.shpasses.