Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider handling of no-text inputs to make_string / make_symbol #327

Closed
toddjonker opened this issue Jun 13, 2024 · 1 comment
Closed

Comments

@toddjonker
Copy link
Contributor

The spec currently states that make_string

Produces a non-null, unannotated string containing the concatenated content produced by the arguments. Nulls and annotations are discarded.

There's still some discussion, eg at amazon-ion/ion-tests#100 (comment)

The spec also ignores $0 and absent shared symbols. See also #324

BTW the case that gives me the most pause is with one null, eg (make_symbol null.string) which one might expect to return null.symbol not "". That's fairly useless for E-expression invocation (you could just write the desired null directly), but in templates it enables coercing any string to a symbol.

@popematt
Copy link
Contributor

popematt commented Dec 4, 2024

Completed in #342. Passing nulls and symbols with unknown text to make_string or make_symbol must cause an error to be raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants