Refactor attachment classes

Author: amanda11

CHANGES.md

@@ -1,6 +1,6 @@
 # Change Log
 
-## 0.3.9
+## 0.4.0
 - Add support for upload attachment and get attachment metadata
 
 ## 0.3.8

actions/get_attachment.py

@@ -2,12 +2,5 @@
 
 
 class GetAttachmentAction(BaseAction):
-    def run(self, table, sys_id):
-        s = self.client
-        api_path = "/attachment/{}".format(sys_id)
-        r = s.resource(api_path=api_path)
-        records = r.get(query={})
-        output = []
-        for record in records.all():
-            output.append(record)
-        return output
+    def run(self, sys_id):
+        return self.get_attachments(sys_id)

actions/get_attachment.yaml

@@ -5,10 +5,6 @@ description: "Gets metadata for an attachment"
 enabled: true
 entry_point: "get_attachment.py"
 parameters:
-  table:
-    type: "string"
-    description: "Table to take action on"
-    required: true
   sys_id:
     type: "string"
     description: "Sys-id of attachment to retrieve"

actions/get_attachments.py

@@ -2,11 +2,5 @@
 
 
 class GetAttachmentsAction(BaseAction):
-    def run(self, table):
-        s = self.client
-        r = s.resource(api_path="/attachment")
-        records = r.get(query={})
-        output = []
-        for record in records.all():
-            output.append(record)
-        return output
+    def run(self):
+        return self.get_attachments()

actions/get_attachments.yaml

@@ -1,11 +1,6 @@
 ---
 name: "get_attachments"
 runner_type: "python-script"
-description: "Gets meta-data for all attachments for specified table"
+description: "Gets meta-data for all attachments"
 enabled: true
 entry_point: "get_attachments.py"
-parameters:
-  table:
-    type: "string"
-    description: "Table to take action on"
-    required: true

actions/lib/actions.py

@@ -18,3 +18,11 @@ def _get_client(self):
             client.parameters.add_custom(self.config['custom_params'])
 
         return client
+
+    def get_attachments(self, sys_id=None):
+        api_path="/attachment"
+        if sys_id:
+            api_path+="/{}".format(sys_id)
+        r = self.client.resource(api_path=api_path)
+        records = r.get(query={})
+        return [r for r in records.all()]

pack.yaml

@@ -5,7 +5,7 @@ description: ServiceNow Integration Pack
 keywords:
   - servicenow
   - incident management
-version: 0.3.9
+version: 0.4.0
 python_versions:
   - "2"
   - "3"