You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the NAT-PMP implementation of this library will never succeed when performing any actions due to a missing property when pushing the request to the _queue, which causes onMessage to always return early.
The op property is missing from the following _queue push:
To always fail, as the parsed.op - SERVER_DELTA will never equal undefined.
From local testing, I can confirm this does add the mapping via NAT-PMP, but will never fully handle the response, causing the request to always timeout, falling back to NAT-UPNP, which may not be supported in all environments.
The text was updated successfully, but these errors were encountered:
Hey,
Currently the NAT-PMP implementation of this library will never succeed when performing any actions due to a missing property when pushing the request to the
_queue
, which causesonMessage
to always return early.The
op
property is missing from the following_queue
push:nat-api/lib/pmp/index.js
Line 178 in 16fd1e4
Which is causing this check:
nat-api/lib/pmp/index.js
Line 260 in 16fd1e4
To always fail, as the
parsed.op - SERVER_DELTA
will never equalundefined
.From local testing, I can confirm this does add the mapping via NAT-PMP, but will never fully handle the response, causing the request to always timeout, falling back to NAT-UPNP, which may not be supported in all environments.
The text was updated successfully, but these errors were encountered: