-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GFF seqid may violate gff3 spec #18
Comments
Oh yes, this is a mistake on my end, sorry 🤐 I'll update this part for |
I'm pushing a pre-release that you can test on your side ( |
Wow that was fast, thank you I'll test this out soon! |
Marking this as fixed since |
Thanks for this tool! One comment and a request:
It looks like the GFF output format here is slightly different than prodigal, and (maybe) the gff3 specs. This is preventing us using pyrodigal as a drop-in replacement.
Prodigal uses the input contig name for the
seqid
, while pyrodigal usesprefix/gene_{i}
, which seems to violate this spec:The landmark for the gene coordinates obviously cannot be the gene id itself.
What would be great is if instead the prefix could modify the
ID
component of the_gene_data
which would add an enhancement over the gff output provided by prodigal without violating the spec.The text was updated successfully, but these errors were encountered: