From 9cf43aacf55d01b5e8bc7945ab3d2ef842910d81 Mon Sep 17 00:00:00 2001 From: Aga Dufrat Date: Wed, 29 Jan 2025 12:38:05 +0000 Subject: [PATCH] Correct Lint/Void: Literal used in void context rubocop offence app/controllers/anonymous_feedback/problem_reports_controller.rb:78:11: W: Lint/Void: Literal true used in void context. true ^^^^ --- .../anonymous_feedback/problem_reports_controller.rb | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/controllers/anonymous_feedback/problem_reports_controller.rb b/app/controllers/anonymous_feedback/problem_reports_controller.rb index c2fc3ed1..c8abb057 100644 --- a/app/controllers/anonymous_feedback/problem_reports_controller.rb +++ b/app/controllers/anonymous_feedback/problem_reports_controller.rb @@ -74,11 +74,7 @@ def mark_supplied_reports_as_reviewed_and_spam review_attrs = { reviewed: true, marked_as_spam: } - if problem_report.update(review_attrs) - true - else - false - end + problem_report.update(review_attrs) ? true : false end rescue ActiveRecord::RecordNotFound false