Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: allegro/hermes
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e6336ea4682788b64ce1c4d9e8983efb939a97f7
Choose a base ref
..
head repository: allegro/hermes
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ba9c6b45f749357021bca22da88ed44628b1e6ff
Choose a head ref
Showing with 4 additions and 4 deletions.
  1. +4 −4 ...rc/integrationTest/java/pl/allegro/tech/hermes/integrationtests/slow/KafkaReadinessCheckTest.java
8 changes: 4 additions & 4 deletions ...rationTest/java/pl/allegro/tech/hermes/integrationtests/slow/KafkaReadinessCheckTest.java
View file
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@
import org.testcontainers.lifecycle.Startable;
import pl.allegro.tech.hermes.api.Topic;
import pl.allegro.tech.hermes.integrationtests.client.FrontendTestClient;
import pl.allegro.tech.hermes.integrationtests.setup.HermesInitHelper;
import pl.allegro.tech.hermes.integrationtests.setup.HermesFrontendTestApp;
import pl.allegro.tech.hermes.integrationtests.setup.HermesInitHelper;
import pl.allegro.tech.hermes.integrationtests.setup.HermesManagementTestApp;
import pl.allegro.tech.hermes.integrationtests.setup.HermesTestApp;
import pl.allegro.tech.hermes.test.helper.containers.BrokerId;
@@ -24,7 +24,7 @@
import static org.springframework.http.HttpStatus.SERVICE_UNAVAILABLE;
import static pl.allegro.tech.hermes.api.Topic.Ack.ALL;
import static pl.allegro.tech.hermes.integrationtests.HermesAssertions.assertThat;
import static pl.allegro.tech.hermes.test.helper.builder.TopicBuilder.randomTopic;
import static pl.allegro.tech.hermes.test.helper.builder.TopicBuilder.topicWithRandomName;

public class KafkaReadinessCheckTest {

@@ -38,8 +38,8 @@ public static void setup() {
HermesTestApp management = new HermesManagementTestApp(hermesZookeeper, kafka)
.start();
HermesInitHelper hermesInitHelper = new HermesInitHelper(management.getPort());
topic = hermesInitHelper.createGroupAndTopic(
randomTopic("someRandomGroup", "someRandomTopic")
topic = hermesInitHelper.createTopic(
topicWithRandomName()
.withAck(ALL)
.build()
);