Skip to content

Upgrade to youtube-dl-exec@3 #5

@darthwalsh

Description

@darthwalsh

I can't install this package on my system, because "youtube-dl-exec": "^1.1.1", in package.json is too old, and hardcodes python even though modern systems often don't have that installed:

$ npm i youtube-dl-exec@1.3.4
(node:59126) ExperimentalWarning: CommonJS module /opt/homebrew/lib/node_modules/npm/node_modules/debug/src/node.js is loading ES Module /opt/homebrew/lib/node_modules/npm/node_modules/supports-color/index.js using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
npm error code 1
npm error path /private/var/folders/v7/p7wfv43s725dwxcp5fn3vyz80000gp/T/DEL-20241030-11-40-51.64/node_modules/youtube-dl-exec
npm error command failed
npm error command sh -c npx bin-version-check-cli python ">=2"
npm error (node:59154) ExperimentalWarning: CommonJS module /opt/homebrew/lib/node_modules/npm/node_modules/debug/src/node.js is loading ES Module /opt/homebrew/lib/node_modules/npm/node_modules/supports-color/index.js using require().
npm error Support for loading ES Module in require() is an experimental feature and might change at any time
npm error (Use `node --trace-warnings ...` to show where the warning was created)
npm error Error: Couldn't find version of `python`
npm error     at binaryVersion (file:///Users/walshca/.npm/_npx/7b761a280cf4a94b/node_modules/bin-version/index.js:55:8)
npm error     at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
npm error     at async binaryVersionCheck (file:///Users/walshca/.npm/_npx/7b761a280cf4a94b/node_modules/bin-version-check/index.js:14:18)

Installing youtube-dl-exec@3.0.10 worked fine: it has more checks to first look for python3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions