Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array1DTracer Should Not Subclass Array2DTracer #5

Open
MarkKoz opened this issue Jul 28, 2019 · 1 comment
Open

Array1DTracer Should Not Subclass Array2DTracer #5

MarkKoz opened this issue Jul 28, 2019 · 1 comment

Comments

@MarkKoz
Copy link
Member

MarkKoz commented Jul 28, 2019

It ends up inheriting functions which are not applicable to it (selectRow, selectCol, etc).
@64json
Copy link
Member

64json commented Jul 28, 2019 •
edited
Loading

Yea I also noticed the issue and made Array1DTracer in tracers.js directly extend Tracer. I haven't fixed tracers.java and tracers.cpp, but I will fix them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkKoz @64json