Add static qualifiers to json creators for onCompletion enum serialization. (#221)

Author: egieseke

src/main/java/com/algorand/algosdk/transaction/Transaction.java

@@ -1165,8 +1165,7 @@ public enum OnCompletion {
             this.serializedName = serializedName;
         }
 
-        @JsonCreator
-        public OnCompletion String(String name) {
+        public static OnCompletion String(String name) {
             for(OnCompletion oc : values()) {
                 if (oc.serializedName.equalsIgnoreCase(name)) {
                     return oc;
@@ -1176,7 +1175,7 @@ public OnCompletion String(String name) {
         }
 
         @JsonCreator
-        public OnCompletion String(int value) {
+        public static OnCompletion forValue(int value) {
             for(OnCompletion oc : values()) {
                 if (oc.serializedValue == value) {
                     return oc;

src/test/java/com/algorand/algosdk/transaction/TestTransaction.java

@@ -5,13 +5,18 @@
 import com.algorand.algosdk.mnemonic.Mnemonic;
 import com.algorand.algosdk.util.Encoder;
 import com.algorand.algosdk.util.TestUtil;
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.annotation.JsonSerialize;
 import org.junit.jupiter.api.Test;
 
 import java.io.*;
 import java.math.BigInteger;
 import java.nio.charset.StandardCharsets;
 import java.security.NoSuchAlgorithmException;
 import java.util.Arrays;
+import java.util.Objects;
 
 import static org.assertj.core.api.Assertions.*;
 
@@ -65,6 +70,46 @@ public void testSerialization() throws Exception {
         assertEqual(o, tx);
     }
 
+    @Test
+    public void testPaymentTransactionJsonSerialization() throws Exception {
+        Address from = new Address("VKM6KSCTDHEM6KGEAMSYCNEGIPFJMHDSEMIRAQLK76CJDIRMMDHKAIRMFQ");
+        Address to = new Address("CQW2QBBUW5AGFDXMURQBRJN2AM3OHHQWXXI4PEJXRCVTEJ3E5VBTNRTEAE");
+        Transaction tx = Transaction.PaymentTransactionBuilder()
+                .sender(from)
+                .receiver(to)
+                .amount(100)
+                .firstValid(301)
+                .lastValid(1300)
+                .genesisHash(new Digest())
+                .build();
+
+        ObjectMapper objectMapper = new ObjectMapper();
+        String transactionJson = objectMapper.writeValueAsString(tx);
+        final Transaction transaction = objectMapper.readValue(transactionJson, Transaction.class);
+        assertEqual(tx, transaction);
+        String transactionJson1 = objectMapper.writeValueAsString(transaction);
+        assertThat(transactionJson).isEqualTo(transactionJson1);
+    }
+
+    @Test
+    public void testApplicationTransactionJsonSerialization() throws Exception {
+        Address from = new Address("VKM6KSCTDHEM6KGEAMSYCNEGIPFJMHDSEMIRAQLK76CJDIRMMDHKAIRMFQ");
+        Transaction tx = Transaction.ApplicationUpdateTransactionBuilder()
+                .sender(from)
+                .applicationId(100000L)
+                .firstValid(301)
+                .lastValid(1300)
+                .genesisHash(new Digest())
+                .build();
+
+        ObjectMapper objectMapper = new ObjectMapper();
+        String transactionJson = objectMapper.writeValueAsString(tx);
+        final Transaction transaction = objectMapper.readValue(transactionJson, Transaction.class);
+        assertEqual(tx, transaction);
+        String transactionJson1 = objectMapper.writeValueAsString(transaction);
+        assertThat(transactionJson).isEqualTo(transactionJson1);
+    }
+
     @Test
     public void testSerializationMsgpack() throws Exception {
         Address from = new Address("VKM6KSCTDHEM6KGEAMSYCNEGIPFJMHDSEMIRAQLK76CJDIRMMDHKAIRMFQ");