Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on MSVC #9

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

aminya
Copy link

@aminya aminya commented Oct 8, 2020

Fixes #7

@aminya
Copy link
Author

aminya commented Oct 8, 2020

Well, the issue is more than Cmake. The code itself uses Linux types identifiers such as uint which are not in standard c++. It uses some headers that are specific to linux.

❯ cmake --build ./build
CMake is re-running because C:/Users/aminy/Documents/GitHub/Shell/shell-plus-plus/build/src/CMakeFiles/generate.stamp is out-of-date.
  the file 'C:/Users/aminy/Documents/GitHub/Shell/shell-plus-plus/src/CMakeLists.txt'
  is newer than 'C:/Users/aminy/Documents/GitHub/Shell/shell-plus-plus/build/src/CMakeFiles/generate.stamp.depend'
  result='-1'
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19042.
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Users/aminy/Documents/GitHub/Shell/shell-plus-plus/build
Microsoft (R) Build Engine version 16.8.0-preview-20452-03+5dee11854 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  ast.cc
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(76,8): error C2061: syntax error: identifier 'uint' [C:\Users\aminy\Documents\GitH
ub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(83,8): error C2061: syntax error: identifier 'uint' [C:\Users\aminy\Documents\GitH
ub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(90,8): error C2061: syntax error: identifier 'uint' [C:\Users\aminy\Documents\GitH
ub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(146,12): error C3646: 'Line': unknown override specifier [C:\Users\aminy\Documents
\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(146,12): error C2059: syntax error: '(' [C:\Users\aminy\Documents\GitHub\Shell\she
ll-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(146,30): error C2334: unexpected token(s) preceding '{'; skipping apparent functio
n body [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(148,11): error C3646: 'Col': unknown override specifier [C:\Users\aminy\Documents\
GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(148,11): error C2059: syntax error: '(' [C:\Users\aminy\Documents\GitHub\Shell\she
ll-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(148,29): error C2334: unexpected token(s) preceding '{'; skipping apparent functio
n body [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(267,13): error C3646: 'line_': unknown override specifier [C:\Users\aminy\Document
s\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(267,13): error C4430: missing type specifier - int assumed. Note: C++ does not sup
port default-int [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(268,12): error C3646: 'col_': unknown override specifier [C:\Users\aminy\Documents
\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(268,12): error C4430: missing type specifier - int assumed. Note: C++ does not sup
port default-int [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(80,15): error C2065: 'line': undeclared identifier [C:\Users\aminy\Documents\GitHu
b\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(81,14): error C2065: 'col': undeclared identifier [C:\Users\aminy\Documents\GitHub
\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(80,9): error C2614: 'shpp::internal::Token': illegal member initialization: 'line_
' is not a base or member [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(81,9): error C2614: 'shpp::internal::Token': illegal member initialization: 'col_'
 is not a base or member [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(87,15): error C2065: 'line': undeclared identifier [C:\Users\aminy\Documents\GitHu
b\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(88,14): error C2065: 'col': undeclared identifier [C:\Users\aminy\Documents\GitHub
\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(87,9): error C2614: 'shpp::internal::Token': illegal member initialization: 'line_
' is not a base or member [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(88,9): error C2614: 'shpp::internal::Token': illegal member initialization: 'col_'
 is not a base or member [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(94,15): error C2065: 'line': undeclared identifier [C:\Users\aminy\Documents\GitHu
b\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(95,14): error C2065: 'col': undeclared identifier [C:\Users\aminy\Documents\GitHub
\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(94,9): error C2614: 'shpp::internal::Token': illegal member initialization: 'line_
' is not a base or member [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(95,9): error C2614: 'shpp::internal::Token': illegal member initialization: 'col_'
 is not a base or member [C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]
C:\Users\aminy\Documents\GitHub\Shell\shell-plus-plus\src\parser/token.h(101,19): error C2039: 'line_': is not a member of 'shpp::internal::Token' [C:\User
s\aminy\Documents\GitHub\Shell\shell-plus-plus\build\src\shpp.vcxproj]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation fails on MSVC Windows
1 participant