Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Distribute as kubectl plugin via krew #3

Open
dirien opened this issue Sep 5, 2022 · 9 comments
Open

[Feature]: Distribute as kubectl plugin via krew #3

dirien opened this issue Sep 5, 2022 · 9 comments

Comments

@dirien
Copy link

dirien commented Sep 5, 2022

Hi,

just wanted to preflight the idea to create run-job as kubectl plugin and distribute it via krew?

What are your thoughts?

@dirien dirien changed the title [Feature]: Distribute as kubectl plugins via krew [Feature]: Distribute as kubectl plugin via krew Sep 5, 2022
@alexellis
Copy link
Owner

alexellis commented Sep 5, 2022

Hi @dirien would you be willing to do the work for it? What's required?

Note: it is available via arkade get and my brew taps

@dirien
Copy link
Author

dirien commented Sep 6, 2022

Hi @alexellis, yes can do!

At the end, it will be adding the plugin-manifest add submitting initial to the krew repo.

Later we can use the krew-release-bot to automate the process to update the krew-index

@alexellis
Copy link
Owner

Does it require different naming for the binaries?

@dirien
Copy link
Author

dirien commented Sep 6, 2022

For me it looks fine, according the krew guidelines -> https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/

@Abhicodeitout
Copy link

@dirien i would also like to work with you to make that plug-in possible

@alexellis
Copy link
Owner

I'm not sure that @dirien is working on this. Let's close the issue as inactive?

@Abhicodeitout
Copy link

@alexellis if you are working on something related to kubernetes go and docker i will love to contribute

@dirien
Copy link
Author

dirien commented Oct 12, 2022

Hi @alexellis,

I wanted to give you feedback, but some event interfered. The situation is, that Krew plugins must be packaged as .zip or .tar.gz archives.

run-job is nor provided as .zip or .tar.gz archive and I am not sure If you are keen to change this.

Let me know, what you think

@alexellis
Copy link
Owner

If you'd like to contribute a PR to also distribute the binary in that format, I'm OK with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants