null_char_size has wrong size

[xezon]

null_char_size has wrong size.

Is

        /// \brief Size it takes to store the null '\0' char
        /// Of course we could just write 1 in the code, but this gives us
        /// better semantics
        static constexpr size_type null_char_size = '\0';

Should be

        static constexpr size_type null_char_size = sizeof('\0');

[alandefreitas]

Oh... :)

[xezon]

I think it can be simply written as 1, because sizeof('\0') looks confusing when looking at a string made of 2 byte or 4 byte characters.

[alandefreitas]

Is it always 1, though? I don't think C++ reached a consensus on that yet even though it's 1 byte on almost all platforms.

[xezon]

I would expect it is 1x sizeof(char) for chars, 1x sizeof(wchar_t) for multi byte and so on. But I do not know for sure.