Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cpp_version.h with a config file #14

Open
alandefreitas opened this issue Apr 17, 2022 · 0 comments
Open

Replace cpp_version.h with a config file #14

alandefreitas opened this issue Apr 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@alandefreitas
Copy link
Owner

alandefreitas commented Apr 17, 2022

The problem

The cpp_version.h file for custom feature detection is much more than we really need. We don't use most macros it provides and many macros are falling back to the C++ standard version instead of making more elaborate tests. A simple config file would work better for our needs.

Proposed solution

Create a detail/config.hpp with the macros we might need. Remove cpp_version.h and hedley.h from our implementation details.

Alternatives I've considered

A version of cpp_version.h.

Additional context

Implementing a version of cpp_version.h as a separate library still has a lot of merit and would be quite useful. In this separate library, we could ensure the traits work for all compilers we need and then reuse that as needed.

@alandefreitas alandefreitas added the enhancement New feature or request label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant