Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'sticky' is defined as an accessor in class 'CdkColumnDef', but is overridden here in 'NbColumnDefDirective' as an instance property. #3258

Open
1 task
gershonkoral opened this issue Jun 21, 2024 · 6 comments

Comments

@gershonkoral
Copy link

Issue type

I'm submitting a ... (check one with "x")

  • [ x] bug report
  • feature request

Issue description

Current behavior:
When compiling my Angular project with Angular at v18, I get the error

Error: node_modules/@nebular/theme/components/cdk/table/cell.d.ts:38:5 - error TS2610: 'sticky' is defined as an accessor in class 'CdkColumnDef', but is overridden here in 'NbColumnDefDirective' as an instance property.

38     sticky: boolean;

Expected behavior:
Should not have compilation error.

Steps to reproduce:
Import @nebular/theme version 13.0.0 as a module into an angular project of version 18 (latest).

-->

Other information:

npm, node, OS, Browser

<!--
Node, v22.3.0 and npm: v10.8.1
OS: Windows 10
Browser: Firefox
-->

Angular, Nebular

angular: v18.0.4
@theophane-girard
Copy link

Same problem here

@gershonkoral
Copy link
Author

@theophane-girard

A temporary fix that worked for me is to directly modify your @nebular/theme module as follows:

  1. Comment out line 38 sticky: boolean property in node_modules/@nebular/theme/components/cdk/table/cell.d.ts
  2. Comment out line 39 sticky: boolean property in node_modules/@nebular/theme/components/cdk/table/row.d.ts
  3. (Optional) Use patch-package to apply these changes for others on your team.

Hope this helps.

@theophane-girard
Copy link

theophane-girard commented Jun 24, 2024

@theophane-girard

A temporary fix that worked for me is to directly modify your @nebular/theme module as follows:

  1. Comment out line 38 sticky: boolean property in node_modules/@nebular/theme/components/cdk/table/cell.d.ts
  2. Comment out line 39 sticky: boolean property in node_modules/@nebular/theme/components/cdk/table/row.d.ts
  3. (Optional) Use patch-package to apply these changes for others on your team.

Hope this helps.

Imo, that's actually not a good idea and not viable...

for now, i just added this option in tsconfig.json

compilerOptions: {
     // ...
    "skipLibCheck": true
}

@oscarholinger
Copy link

Same here. I used @theophane-girard solution ---> Thank you for that.
I was wondering if this project is going to continue updating, since lately I see it a little abandoned and I don't know I would choose it for future projects, which is a shame since it is very good.

@kisimediaDE
Copy link

Seems to be fixed in the newest version Nebular 14

@oscarholinger
Copy link

skipLibCheck

Updated to Angular 18 and Nebular 14 and seems to be fixed.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants