Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated aspect_ratio logic in phosphor-mask-calculations.fxh #30

Open
akgunter opened this issue Jan 26, 2023 · 0 comments
Open

Duplicated aspect_ratio logic in phosphor-mask-calculations.fxh #30

akgunter opened this issue Jan 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@akgunter
Copy link
Owner

The function get_selected_aspect_ratio() in phosphor-mask-calculations.fxh has duplicated effort. I think I was comparing a switch statement to an if-else chain and forgot to delete one or the other. So now it's doing both. It doesn't cause any real problems, but I need to nuke one of them.

@akgunter akgunter added the bug Something isn't working label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant