Merge pull request owasp-modsecurity#3307 from gberkes/v3/cppcheck_v2_16_upgrade

airween · web-flow · commit fd4564131f53 · 2024-11-23T09:28:08.000Z
Fix: Add false positive cppcheck-suppress for compatibility with upda…
diff --git a/src/utils/system.cc b/src/utils/system.cc
@@ -210,7 +210,7 @@ bool isFile(const std::string& f) {
         return false;
     }
     fstat(fileno(fp), &fileInfo);
-    if (!S_ISREG(fileInfo.st_mode)) {
+    if (!S_ISREG(fileInfo.st_mode)) { // cppcheck-suppress syntaxError ; false positive
         fclose(fp);
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ bool isFile(const std::string& f) {`
`210`	`210`	`return false;`
`211`	`211`	`}`
`212`	`212`	`fstat(fileno(fp), &fileInfo);`
`213`		`- if (!S_ISREG(fileInfo.st_mode)) {`
	`213`	`+ if (!S_ISREG(fileInfo.st_mode)) { // cppcheck-suppress syntaxError ; false positive`
`214`	`214`	`fclose(fp);`
`215`	`215`	`return false;`
`216`	`216`	`}`