-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Datadog : Fix the Pagination in the logs stream #54180
🐛 Source Datadog : Fix the Pagination in the logs stream #54180
Conversation
@VigneshSankar01 is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
…nation-for-logs-stream
/bump-version type="patch"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you.
Hi Team, Would these checks take a lot of time to process? It says I would need authorization to deploy Vercel. Please advice Thanks! |
…nation-for-logs-stream
Hi Team, requesting approval on this, please |
@natikgadzhi @ChristoGrab for approval on vercel and community CI, please! |
@VigneshSankar01 please be patience. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
What
This PR addresses an issue with the pagination strategy in the logs stream for the Datadog Marketplace Connector in Airbyte. The previous pagination logic did not properly iterate through all pages, causing incomplete log retrieval. This update ensures that all logs are pulled correctly.
Link to the Issue: #54161
How
The pagination strategy in the manifest.yaml file has been updated from DefaultPaginator to CursorPagination. The updated strategy now:
This ensures that the logs stream correctly fetches all available logs without missing any records.
Review guide
Key changes are in:
User Impact
Users will now receive all logs from Datadog without missing any entries due to pagination issues.
The connector will function more reliably for log ingestion.
Can this PR be safely reverted and rolled back?
YES 💚 – The changes are limited to the pagination strategy in manifest.yaml. If needed, reverting this PR would restore the previous pagination behavior.