Skip to content

Commit 8c4776a

Browse files
author
Ella Rohm-Ensing
committed
feat: add warning to publish modal about privatizing secrets (#13359)
## What <!-- * Describe what the change is solving. * It helps to add screenshots if it affects the frontend. --> * Close https://github.com/airbytehq/airbyte-internal-issues/issues/8904 * Before we are able to spike on [checking for things that look like secrets in manifests](https://github.com/airbytehq/airbyte-internal-issues/issues/8308), remind the user to check this for themselves before contributing. Copy edits welcome :D ![image](https://github.com/user-attachments/assets/ea466a30-43c1-45b2-b8e5-d015a6f2edd9) ## Can this PR be safely reverted and rolled back? <!-- * If you know that your be safely rolled back, check YES.* * If that is not the case (e.g. a database migration), check NO. * If unsure, leave it blank.* --> - [x] YES 💚 - [ ] NO ❌
1 parent 75e5fa8 commit 8c4776a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

airbyte-webapp/src/components/connectorBuilder/MenuBar/PublishModal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,7 @@ const ContributeToMarketplace: React.FC<InnerModalProps> = ({ onClose, setPublis
420420
<ModalBody>
421421
<FlexContainer direction="column" gap="xl">
422422
<PublishTypeSwitcher selectedPublishType="marketplace" setPublishType={setPublishType} />
423+
<Message type="warning" text={<FormattedMessage id="connectorBuilder.warnPublishSecrets" />} />
423424
<FlexContainer direction="column" gap="none">
424425
<FormControl<ContributeToMarketplaceFormValues>
425426
name="name"

airbyte-webapp/src/locales/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,6 +1512,7 @@
15121512
"connectorBuilder.errorHandlerWarning": "To keep testing times short, <b>retries are disabled in the connector builder</b>. If you want to test retries, please publish your connector and test it in a connection.",
15131513
"connectorBuilder.publishDescription": "Publishes this configuration to your workspace as a custom connector that can be used to create Sources and run syncs",
15141514
"connectorBuilder.releaseNewVersionDescription": "Adds a new version of this custom connector to your workspace",
1515+
"connectorBuilder.warnPublishSecrets": "Contributing makes your connector public. Double-check that all sensitive values (e.g. API Keys, passwords, private domains, etc.) are configured via User Inputs before contributing.",
15151516
"connectorBuilder.setAsActiveVersion.label": "Set as active version",
15161517
"connectorBuilder.setAsActiveVersion.tooltip": "If enabled, will set this configuration as the new active version of your custom connector and update any Sources built on top of it. Only one version can be active per connector.",
15171518
"connectorBuilder.tableViewMode": "Show records as table",

0 commit comments

Comments
 (0)