Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Docker installation #247

Open
5 tasks
FilipeS0usa opened this issue Dec 13, 2024 · 0 comments
Open
5 tasks

Fix: Docker installation #247

FilipeS0usa opened this issue Dec 13, 2024 · 0 comments

Comments

@FilipeS0usa
Copy link

I tried the docker installation and there is some errors while building the image.

Just a quick review of the implementation of docker in general and I can see there's some services that are build inside the image (Ex.: Redis) while this service could be called individually in the docker-compose.yml, at least I think this should be the optimal way of implementing services. And this way we can lock the version of the service and separate it from the rest of the build (app that was developed).

I will make a fork and PR and try to review the full installation and implementation of the project with docker. It can take some time, and I will probably need some help with some questions, but I will do my best.

I'm going to try to leave a list of how this should be implemented or things I think should be optimized:

  • Improve readability of the docker-compose.yml file
  • Review Dockerfile to solve errors while building image
  • Review Services that are build inside the Dockerfile with the installing_deps.sh scripts
  • After reviewing the Dockerfile, review the docker-compose.yml file with the new services
  • The final objective should be build the image and after that we should only execute docker compose up -d and the project should be up and running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant