Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new aiida-core pytest fixtures with SQLite backend #70

Open
danielhollas opened this issue Nov 17, 2024 · 3 comments · May be fixed by #79
Open

Switch to new aiida-core pytest fixtures with SQLite backend #70

danielhollas opened this issue Nov 17, 2024 · 3 comments · May be fixed by #79

Comments

@danielhollas
Copy link
Collaborator

danielhollas commented Nov 17, 2024 •
edited
Loading

Instead of manage/tests/pytest_fixtures.py use tools/pytest_fixtures/ introduced in aiida 2.6.0. These new fixtures use the sqlite_dos storage backend by default. See https://aiida.readthedocs.io/projects/aiida-core/en/stable/topics/plugins.html#plugin-test-fixtures

This should hopefully be more-or-less a drop-in replacement.
@danielhollas
Copy link
Collaborator Author

By quick inspection, the only aiida-core fixture that's in use here is the aiida_localhost in mock_code

https://github.com/aiidateam/aiida-testing/blob/2bf9dfaef5d7658b47f5b31dd1ce81da5c43c53c/aiida_testing/mock_code/__init__.py#L20

https://github.com/aiidateam/aiida-testing/blob/2bf9dfaef5d7658b47f5b31dd1ce81da5c43c53c/aiida_testing/mock_code/_fixtures.py#L121

@ltalirz
Copy link
Member

ltalirz commented Nov 17, 2024

sounds good

@danielhollas
Copy link
Collaborator Author

I am working on this in #79, it works for mock_code but the archive_cache fixture is broken in 2.6 and will need to be fixed (#80). It is unclear if we will be able to support both 2.6 and older versions. I am leaning towards just supporting 2.6 and up to simplify maintenance. We'll see...

@danielhollas danielhollas linked a pull request Dec 4, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new pytest fixtures with SQLite aiidateam/aiida-test-cache
2 participants
@ltalirz @danielhollas