Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exact_highlight_select uses mouse event's coordinates instead of highlight's coordinates #741

Open
hrdl-github opened this issue Jun 9, 2023 · 2 comments · May be fixed by #742
Open

exact_highlight_select uses mouse event's coordinates instead of highlight's coordinates #741

hrdl-github opened this issue Jun 9, 2023 · 2 comments · May be fixed by #742

Comments

@hrdl-github
Copy link
Contributor

I haven't noticed this until now because I usually use single_click_selects_words 1. Sometimes this fails, e.g. in equations or occasionally at the end of sentences, and I switch to character selection mode using double click. When adding a highlight the entire word is selected. This also happens when using single clicks and single_click_selects_words 0.
@ahrm
Copy link
Owner

ahrm commented Jun 9, 2023 •
edited
Loading

There is anexact_highlight_select config option to configure this behavior.

@hrdl-github
Copy link
Contributor Author

Thanks, I hadn't seen that one when looking at the code. That option does not work well when selecting entire words though, as it seems to use the mouse coordinates. I'll fix this sometime this weekend.

@hrdl-github hrdl-github changed the title add_highlight always select entire words exact_highlight_select uses mouse event's coordinates instead of highlight's coordinates Jun 9, 2023
hrdl-github added a commit to hrdl-github/sioyek that referenced this issue Jun 10, 2023
@hrdl-github
Use is_word_selecting to determine word selection mode for highlights
71a24c1 
Fixes ahrm#741.
@hrdl-github hrdl-github linked a pull request Jun 10, 2023 that will close this issue
Open
2 tasks
hrdl-github added a commit to hrdl-github/sioyek that referenced this issue Sep 29, 2023
@hrdl-github
Use is_word_selecting to determine word selection mode for highlights
1139f9e 
Fixes ahrm#741.
hrdl-github added a commit to hrdl-github/sioyek that referenced this issue Nov 27, 2023
@hrdl-github
Use is_word_selecting to determine word selection mode for highlights
9a3659b 
Fixes ahrm#741.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make highlights respect word selection mode hrdl-github/sioyek
2 participants
@ahrm @hrdl-github