Make shortcuts to be able to be disabled

Author: ahpxex

src-tauri/src/shortcuts.rs

@@ -76,6 +76,7 @@ pub async fn setup_shortcuts<R: Runtime>(
     app: AppHandle<R>,
     quick_query: String,
     new_query: String,
+    enabled: bool,
 ) -> Result<(), String> {
     use tauri_plugin_global_shortcut::{GlobalShortcutExt, Shortcut, ShortcutState};
 
@@ -86,6 +87,10 @@ pub async fn setup_shortcuts<R: Runtime>(
         .unregister_all()
         .map_err(|e| format!("Failed to unregister shortcuts: {}", e))?;
 
+    if !enabled {
+      return Ok(());
+    }
+
     // Normalize shortcuts to replace "Mod" with platform-specific key
     let quick_query_normalized = normalize_shortcut(&quick_query);
     let new_query_normalized = normalize_shortcut(&new_query);

src/app/layout.tsx

@@ -31,6 +31,7 @@ export function AppLayout() {
   useGlobalShortcuts({
     quickQuery: settings.keyboard.quickQuery,
     newQuery: settings.keyboard.newQuery,
+    enabled: settings.keyboard.enabled,
     onQuickQuery: (text) => {
       // Ensure we're on the dictionary tab, then run the search.
       navigate("/");

src/features/settings/components/keyboard-tab.tsx

@@ -2,6 +2,7 @@ import { Button } from "@/components/ui/button";
 import { Card, CardContent, CardDescription, CardHeader, CardTitle } from "@/components/ui/card";
 import { KbdInput } from "@/components/ui/kbd-input";
 import { Label } from "@/components/ui/label";
+import { Switch } from "@/components/ui/switch";
 import { useSettings } from "@/features/settings/hooks/use-settings";
 import { toast } from "sonner";
 import { useTranslation } from "react-i18next";
@@ -24,10 +25,26 @@ export function KeyboardTab() {
         <CardHeader>
           <CardTitle>{t("settings.keyboard.shortcuts.title")}</CardTitle>
           <CardDescription>
-            Configure the key combinations for quick interactions.
+            {t("settings.keyboard.shortcuts.description")}
           </CardDescription>
         </CardHeader>
         <CardContent className="grid gap-4">
+          <div className="flex items-center justify-between gap-4 rounded-lg border bg-muted/40 px-4 py-3">
+            <div className="space-y-1">
+              <p className="text-sm font-medium">
+                {t("settings.keyboard.shortcuts.enable_label")}
+              </p>
+              <p className="text-xs text-muted-foreground">
+                {t("settings.keyboard.shortcuts.enable_helper")}
+              </p>
+            </div>
+            <Switch
+              checked={settings.keyboard.enabled}
+              onCheckedChange={(checked) =>
+                updateKeyboard({ enabled: checked })
+              }
+            />
+          </div>
           <div className="grid gap-2">
             <Label htmlFor="shortcut-quick">{t("settings.keyboard.shortcuts.quick_query")}</Label>
             <KbdInput

src/shared/hooks/use-global-shortcuts.ts

@@ -5,13 +5,15 @@ import { listen } from "@tauri-apps/api/event";
 interface UseGlobalShortcutsOptions {
   quickQuery: string;
   newQuery: string;
+  enabled: boolean;
   onQuickQuery: (text: string) => void;
   onNewQuery: () => void;
 }
 
 export function useGlobalShortcuts({
   quickQuery,
   newQuery,
+  enabled,
   onQuickQuery,
   onNewQuery,
 }: UseGlobalShortcutsOptions) {
@@ -22,14 +24,15 @@ export function useGlobalShortcuts({
         await invoke("setup_shortcuts", {
           quickQuery,
           newQuery,
+          enabled,
         });
       } catch (error) {
         console.error("Failed to setup shortcuts:", error);
       }
     };
 
     setupShortcuts();
-  }, [quickQuery, newQuery]);
+  }, [quickQuery, newQuery, enabled]);
 
   useEffect(() => {
     // Listen for quick-query event (clipboard text)

src/shared/locales/en/translation.json

@@ -299,6 +299,9 @@
     "keyboard": {
       "shortcuts": {
         "title": "Shortcuts",
+        "description": "Configure global hotkeys for copying selections or opening a fresh query.",
+        "enable_label": "Enable global shortcuts",
+        "enable_helper": "When disabled, keyboard shortcuts are ignored until you turn them back on.",
         "quick_query": "Quick query",
         "new_query": "New query",
         "reset": "Reset to defaults"

src/shared/locales/zh/translation.json

@@ -299,6 +299,9 @@
     "keyboard": {
       "shortcuts": {
         "title": "快捷键",
+        "description": "配置全局快捷键，便于快速复制选中文本或打开新查询。",
+        "enable_label": "启用全局快捷键",
+        "enable_helper": "关闭后，按下快捷键不会触发操作，重新开启即可恢复。",
         "quick_query": "快速查询",
         "new_query": "新查询",
         "reset": "重置为默认"

src/shared/state/settings.ts

@@ -30,6 +30,7 @@ export const defaultSettings: AppSettings = {
   keyboard: {
     quickQuery: "Mod+Enter",
     newQuery: "Mod+Shift+K",
+    enabled: true,
   },
   about: {
     version: "0.1.0",

src/shared/types/settings.ts

@@ -31,6 +31,7 @@ export type DictionarySettings = {
 export type KeyboardShortcutSettings = {
   quickQuery: string;
   newQuery: string;
+  enabled: boolean;
 };
 
 export type AboutMetadata = {