Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The input parameter 'vad_filter' is not being used in 'faster_whisper' #189

Open
ask51620 opened this issue Jan 25, 2024 · 2 comments
Open

Comments

@ask51620
Copy link

I've noticed that the 'vad_filter' parameter is being included here, but the actual condition for determining whether it's true or not is based on 'word_timestamps.'

I believe this doesn't seem logical. Can we make adjustments to this?

https://github.com/ahmetoner/whisper-asr-webservice/blob/main/app/faster_whisper/core.py#L48

@wheynelau
Copy link

Hmm maybe its the existence of word_timestamps that decides the vad filter in whisper? I have never worked with whisper but thats my guess

@ask51620
Copy link
Author

Actually, I think the wording here should be corrected to
if vad_filter:
We actually have the parameter vad_filter, but we're not using it.

ahmetoner added a commit that referenced this issue Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants