NEW: Add omit column feature #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 📦 NEW: Reverse sorting flag * 📦 NEW: Reverse data sorting using reverse flag * 📖 DOC: Reverse sorting
Co-authored-by: Firas Dib <[email protected]>
* 📦 NEW: NonVerbose * 👌 IMPROVE: Rename option Co-authored-by: Touch Sungkawichai <[email protected]> Co-authored-by: Ahmad Awais ⚡️ <[email protected]>
--omit=cases_cases-today_wrongINput_deaths will omit all valid keys wrong keys will simply be ignored
� Conflicts: � changelog.md � index.js � package.json � utils/cli.js � utils/getCountries.js � utils/getCountry.js � utils/getStates.js
Inukares
commented
Mar 25, 2020
| const states = input === 'states' ? true : false; | ||
| const states = input === 'states'; |
There was a problem hiding this comment.
It's the same code written simpler.
Comment on lines
-48
to
+50
| const table = !states | ||
| ? new Table({ head, style, chars: border }) | ||
| : new Table({ head: headStates, style, chars: border }); | ||
| const tableHead = states ? headStates : head; | ||
| const table = new Table({ head: tableHead, style, chars: border }); |
There was a problem hiding this comment.
logic for table was complex - it started with negation even though there was no real reason for it. As I needed this piece of code I refactored it a little bit for easier maintenance.
Comment on lines
-55
to
+57
| await getCountry(spinner, table, states, country); | ||
| await getStates(spinner, table, states, options); | ||
| await getCountries(spinner, table, states, country, options); | ||
| await getCountry({ spinner, table, states, country, tableHead }); | ||
| await getStates({ spinner, table, states, options, tableHead }); | ||
| await getCountries({ spinner, table, states, country, options, tableHead }); |
There was a problem hiding this comment.
Due to multiple parameters I refactored getCountry, getStates and getCountries to accept object.
|
It is a good idea to use "comma" separated list as it has common use in cli list parameters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47
First of all, I'd like to say I'm extremely happy to participate in this cool project, great idea @ahmadawais!
This pull request enables feature to omit whole column(s) from output, separated by
_.Wrong keys are simply ignored.