Skip to content

Repo hygiene: 21 ruff errors and open CodeQL findings outside the capture engines #77

Description

@imran-siddique

Found while working on the capture engines and deliberately not fixed there, to keep those pull requests reviewable. All pre-existing.

21 ruff errors at --target-version py39, in integrations/sentinel, integrations/comply54 and decisionassure. The capture engines, the core and scripts/ are clean, so a repo-wide ruff check cannot currently be a gate.

Open CodeQL findings:

  • py/stack-trace-exposure, medium, five instances in integrations/sentinel/sentinel/server.py (lines 128, 131, 299, 311, 347). Stack traces reaching an external caller. This one is worth doing first: it is a real information leak in a service, not a lint preference.
  • PinnedDependenciesID, medium, across ramen-ai-cmcp-conformance.yml, scheduled-agents-tests.yml, agentrust-codex-tests.yml, spendguard-conformance.yml, claude-code-tests.yml, codeql.yml, scorecard.yml, and integrations/sentinel/Dockerfile: unpinned pip install commands, unpinned GitHub actions, and an unpinned container base image.

The pinning findings matter more than usual here, given this repository publishes supply-chain integrity tooling. The newer workflows pin actions by SHA; the older ones do not.

Suggest splitting: one pull request for the stack-trace exposures, one for pinning, then make repo-wide ruff a required check once it is clean.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions