Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ refactor ] rationalise the common APIs for List and Vec versions of Data.*.Relation.Binary.Lex.* #2687

Open
jamesmckinna opened this issue Mar 28, 2025 · 0 comments

Comments

@jamesmckinna
Copy link
Contributor

I started thinking about this with #2679 and then #2682 / #2683 ...

But this PR is really more about trying to identify a 'common' API for the lexicographic ordering(s) on Vec and List, and with that, the emphasis seems more to be about the 'atomic' properties such as Symmetric etc.

Originally posted by @jamesmckinna in #2679

Now, the APIs are not exactly the same (cf. the comments on #2682 re: WellFounded), but there is enough in common that I think this is worthwhile doing, even if it isn't entirely obvious that there is an actual DRY gain, merely one of 'cognate duplication'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant