Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transforms of Elemwise do not work with DimShuffle lifting #207

Open
brandonwillard opened this issue Dec 2, 2022 · 0 comments
Open

Transforms of Elemwise do not work with DimShuffle lifting #207

brandonwillard opened this issue Dec 2, 2022 · 0 comments
Labels
bug Something isn't working graph rewriting Involves the implementation of rewrites to Aesara graphs help wanted Extra attention is needed important This label is used to indicate priority over things not given this label rv-transforms Involves transforms applied to random variables

Comments

@brandonwillard
Copy link
Member

The Elemwise subclass approach to transforms introduced by #26 does not work with Aesara's local_dimshuffle_lift canonicalization. This is evident after fixing #170.
@brandonwillard brandonwillard added bug Something isn't working help wanted Extra attention is needed important This label is used to indicate priority over things not given this label graph rewriting Involves the implementation of rewrites to Aesara graphs rv-transforms Involves transforms applied to random variables labels Dec 2, 2022
brandonwillard added a commit to brandonwillard/aeppl that referenced this issue Dec 2, 2022
@brandonwillard
Fix incorrect use of rewrite DB position values
3ce46e4 
Re-positionings of the current rewrites cannot be applied due to aesara-devs#207.
brandonwillard added a commit to brandonwillard/aeppl that referenced this issue Dec 2, 2022
@brandonwillard
Fix incorrect use of rewrite DB position values
d880048 
Re-positionings of the current rewrites cannot be applied due to aesara-devs#207.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working graph rewriting Involves the implementation of rewrites to Aesara graphs help wanted Extra attention is needed important This label is used to indicate priority over things not given this label rv-transforms Involves transforms applied to random variables
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandonwillard