Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native runtime] BSOD on pointer buffer overruns and invalid memory access #709

Closed
JerwuQu opened this issue Apr 18, 2024 · 2 comments
Closed

[native runtime] BSOD on pointer buffer overruns and invalid memory access #709

JerwuQu opened this issue Apr 18, 2024 · 2 comments

Comments

@JerwuQu
Copy link
Contributor

JerwuQu commented Apr 18, 2024

See this comment for previous discussion #599 (review).

Functions that take pointers in the C runtime should check that they are valid rather than silently trim any out-of-bounds access. If such cases are detected, BSOD so the user can fix the issue.
yamt added a commit to yamt/wasm4 that referenced this issue Aug 14, 2024
@yamt
native runtime: implement memory bounds check
0be3938 
Fixes:
aduros#750
aduros#709
@yamt yamt mentioned this issue Aug 14, 2024
Merged
yamt added a commit to yamt/wasm4 that referenced this issue Aug 14, 2024
@yamt
native runtime: implement memory bounds check
0733fb2 
Fixes:
aduros#750
aduros#709
yamt added a commit to yamt/wasm4 that referenced this issue Aug 15, 2024
@yamt
native runtime: implement memory bounds check
a40121a 
Fixes:
aduros#750
aduros#709
yamt added a commit to yamt/wasm4 that referenced this issue Aug 15, 2024
@yamt
native runtime: implement memory bounds check
b241def 
Fixes:
aduros#750
aduros#709
@JerwuQu
Copy link
Contributor Author

JerwuQu commented Dec 7, 2024

Fixed!

@JerwuQu JerwuQu closed this as completed Dec 7, 2024
@aduros
Copy link
Owner

aduros commented Dec 7, 2024

Fixed by #751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aduros @JerwuQu