Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solaris VagrantPlaybookCheck fails due to change of ssh host key during playbook execution #2244

Closed
sxa opened this issue Jun 30, 2021 · 3 comments · Fixed by #2250
Closed
Labels
Milestone

Comments

@sxa
Copy link
Member

sxa commented Jun 30, 2021

Ref: #2216 (comment)
Probably introduced by #2220

@sxa sxa added the bug label Jun 30, 2021
@sxa sxa changed the title Solkaris VagrantPlaybookCheck fails due to change of ssh host key during playbook execution Solaris VagrantPlaybookCheck fails due to change of ssh host key during playbook execution Jun 30, 2021
@gdams
Copy link
Member

gdams commented Jul 5, 2021

@sxa is it worth removing Solaris from the jenkins vagrant check job. The GitHub actions check that we have in place seems far more stable and provides the same level of coverage

@sxa
Copy link
Member Author

sxa commented Jul 5, 2021

(On a separate note, as Andreas did I have a preference for not relying on free github minutes for hefty stuff like this but that's a separate discussion)

VPC is testing more than just the playbooks so the assertion that it has the same level of coverage is false. The only reason that the actions check is not failing is because it doesn't try to connect to the machine after the playbook has finished executing (i.e. when the host key has changed). This has flagged a legitimate problem I believe, and we should try and retain the key if it is possible to do so.

@sxa
Copy link
Member Author

sxa commented Jul 6, 2021

Confirmed again that https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1211/ has resolved this problem so this is ready for approval.

@sxa sxa closed this as completed in #2250 Jul 6, 2021
@karianna karianna added this to the July 2021 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants