Skip to content

Commit 9f5640e

Browse files
committed
feat(card): update styles to use refreshed token
1 parent 5957257 commit 9f5640e

File tree

8 files changed

+77
-178
lines changed

8 files changed

+77
-178
lines changed

.changeset/spotty-bats-deny.md

+42
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
---
2+
"@spectrum-css/card": major
3+
---
4+
5+
Previously:
6+
7+
```css
8+
.spectrum-Card.is-selected::before {
9+
background-color: rgba(
10+
var(
11+
--mod-card-selected-background-color-rgb,
12+
var(--spectrum-card-selected-background-color-rgb)
13+
),
14+
var(--spectrum-card-selected-background-opacity)
15+
);
16+
}
17+
```
18+
19+
Styles now use `--spectrum-card-selection-background-color` which maps to a transparent global property of `--spectrum-transparent-(black|white)-600` depending on color context.
20+
21+
Updated:
22+
23+
```css
24+
.spectrum-Card.is-selected::before {
25+
background-color: var(
26+
--mod-card-background-color-selected,
27+
var(--spectrum-card-selection-background-color)
28+
);
29+
}
30+
```
31+
32+
#### Removed variants
33+
34+
Removed the quiet variant which is no longer supported in Spectrum 2.
35+
36+
#### Removed/replaced properties
37+
38+
- `--mod-card-selected-background-color-rgb`. Use `--mod-card-background-color-selected` to override the selected background color.
39+
- `--mod-card-content-margin-top-quiet`. Use `--mod-card-content-margin-top` with appropriate selectors to override.
40+
- `--mod-card-minimum-width-quiet`. Use `--mod-card-minimum-width` with appropriate selectors to override.
41+
- `--mod-card-actions-background-color-rgb`. No replacement, using token value `--spectrum-card-selection-background-color` directly.
42+
- `--mod-card-actions-background-color-opacity`. No replacement, using token value `--spectrum-card-selection-background-color` directly.

.markdownlint.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "markdownlint/style/prettier",
33
"first-line-h1": false,
4-
"no-inline-html": false,
4+
"no-inline-html": false,
55
"no-bare-urls": false,
66
"no-duplicate-heading": {
77
"siblings_only": true

.prettierignore

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
**/.svn
44
**/.hg
55
**/node_modules
6+
yarn.lock
67

78
# Compiled and generated files
89
dist

components/card/dist/metadata.json

+3-26
Original file line numberDiff line numberDiff line change
@@ -22,23 +22,6 @@
2222
".spectrum-Card--horizontal .spectrum-Card-preview",
2323
".spectrum-Card--horizontal .spectrum-Card-title",
2424
".spectrum-Card--horizontal:hover .spectrum-Card-preview",
25-
".spectrum-Card--quiet",
26-
".spectrum-Card--quiet .spectrum-Card-body",
27-
".spectrum-Card--quiet .spectrum-Card-footer",
28-
".spectrum-Card--quiet .spectrum-Card-preview",
29-
".spectrum-Card--quiet .spectrum-Card-preview:after",
30-
".spectrum-Card--quiet .spectrum-Card-preview:before",
31-
".spectrum-Card--quiet.is-drop-target",
32-
".spectrum-Card--quiet.is-drop-target .spectrum-Card-preview",
33-
".spectrum-Card--quiet.is-drop-target .spectrum-Card-preview:before",
34-
".spectrum-Card--quiet.is-focused .spectrum-Card-preview:after",
35-
".spectrum-Card--quiet.is-focused:after",
36-
".spectrum-Card--quiet.is-selected .spectrum-Card-preview",
37-
".spectrum-Card--quiet.is-selected .spectrum-Card-preview:before",
38-
".spectrum-Card--quiet:before",
39-
".spectrum-Card--quiet:focus .spectrum-Card-preview:after",
40-
".spectrum-Card--quiet:focus:after",
41-
".spectrum-Card--quiet:hover .spectrum-Card-preview",
4225
".spectrum-Card-actionButton",
4326
".spectrum-Card-actions",
4427
".spectrum-Card-body",
@@ -55,11 +38,11 @@
5538
".spectrum-Card.is-drop-target",
5639
".spectrum-Card.is-focused .spectrum-Card-actions",
5740
".spectrum-Card.is-focused .spectrum-Card-quickActions",
41+
".spectrum-Card.is-selected",
5842
".spectrum-Card.is-selected .spectrum-Card-actions",
5943
".spectrum-Card.is-selected .spectrum-Card-quickActions",
6044
".spectrum-Card.is-selected:before",
6145
".spectrum-Card.spectrum-Card--gallery",
62-
".spectrum-Card.spectrum-Card--quiet",
6346
".spectrum-Card:after",
6447
".spectrum-Card:before",
6548
".spectrum-Card:focus .spectrum-Card-actions",
@@ -74,8 +57,6 @@
7457
],
7558
"modifiers": [
7659
"--mod-animation-duration-100",
77-
"--mod-card-actions-background-color-opacity",
78-
"--mod-card-actions-background-color-rgb",
7960
"--mod-card-actions-border-radius",
8061
"--mod-card-actions-drop-shadow-blur",
8162
"--mod-card-actions-drop-shadow-color",
@@ -86,6 +67,7 @@
8667
"--mod-card-animation-duration",
8768
"--mod-card-background-color",
8869
"--mod-card-background-color-hover",
70+
"--mod-card-background-color-selected",
8971
"--mod-card-body-font-color",
9072
"--mod-card-body-font-family",
9173
"--mod-card-body-font-size",
@@ -103,7 +85,6 @@
10385
"--mod-card-border-width",
10486
"--mod-card-content-margin-bottom",
10587
"--mod-card-content-margin-top",
106-
"--mod-card-content-margin-top-quiet",
10788
"--mod-card-corner-radius",
10889
"--mod-card-divider-color",
10990
"--mod-card-focus-indicator-color",
@@ -116,7 +97,6 @@
11697
"--mod-card-horizontal-body-padding",
11798
"--mod-card-horizontal-preview-padding",
11899
"--mod-card-minimum-width",
119-
"--mod-card-minimum-width-quiet",
120100
"--mod-card-preview-background-color",
121101
"--mod-card-preview-background-color-hover",
122102
"--mod-card-preview-border-width-selected",
@@ -134,8 +114,6 @@
134114
"--mod-overlay-animation-duration"
135115
],
136116
"component": [
137-
"--spectrum-card-actions-background-color-opacity",
138-
"--spectrum-card-actions-background-color-rgb",
139117
"--spectrum-card-actions-border-radius",
140118
"--spectrum-card-actions-drop-shadow-blur",
141119
"--spectrum-card-actions-drop-shadow-color",
@@ -172,7 +150,7 @@
172150
"--spectrum-card-preview-minimum-height",
173151
"--spectrum-card-selected-background-color-rgb",
174152
"--spectrum-card-selected-background-opacity",
175-
"--spectrum-card-selection-background-color-opacity",
153+
"--spectrum-card-selection-background-color",
176154
"--spectrum-card-selection-background-size",
177155
"--spectrum-card-subtitle-padding-right",
178156
"--spectrum-card-title-font-color",
@@ -202,7 +180,6 @@
202180
"--spectrum-focus-indicator-color",
203181
"--spectrum-focus-indicator-thickness",
204182
"--spectrum-gray-100",
205-
"--spectrum-gray-100-rgb",
206183
"--spectrum-gray-200",
207184
"--spectrum-heading-color",
208185
"--spectrum-heading-line-height",

components/card/index.css

+26-52
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@
1212
*/
1313

1414
.spectrum-Card {
15-
--spectrum-card-border-color: var(--spectrum-gray-100);
16-
--spectrum-card-border-color-hover: var(--spectrum-gray-200);
17-
--spectrum-card-divider-color: var(--spectrum-gray-200);
18-
--spectrum-card-preview-background-color: var(--spectrum-gray-100);
19-
--spectrum-card-preview-background-color-hover: var(--spectrum-gray-200);
15+
--spectrum-card-border-color: var(--mod-card-border-color, var(--spectrum-gray-100));
16+
--spectrum-card-border-color-hover: var(--mod-card-border-color-hover, var(--spectrum-gray-200));
17+
--spectrum-card-border-color-selected: var(--mod-card-border-color-selected, var(--spectrum-blue-700));
18+
19+
--spectrum-card-divider-color: var(--mod-card-divider-color, var(--spectrum-gray-200));
20+
--spectrum-card-preview-background-color: var(--mod-card-preview-background-color, var(--mod-card-background-color, var(--spectrum-gray-100)));
21+
--spectrum-card-preview-background-color-hover: var(--mod-card-preview-background-color-hover, var(--mod-card-background-color-hover, var(--spectrum-gray-200)));
2022

2123
/* Default Layout */
2224
--spectrum-card-background-color: var(--mod-card-background-color, var(--spectrum-background-layer-2-color));
@@ -30,7 +32,6 @@
3032

3133
--spectrum-card-border-width: var(--mod-card-border-width, var(--spectrum-border-width-100));
3234
--spectrum-card-corner-radius: var(--mod-card-corner-radius, var(--spectrum-corner-radius-100));
33-
--spectrum-card-border-color-selected: var(--mod-card-border-color-selected, var(--spectrum-blue-700));
3435

3536
/* Typography */
3637
--spectrum-card-title-font-family: var(--mod-card-title-font-family, var(--spectrum-sans-font-family-stack));
@@ -52,9 +53,6 @@
5253
--spectrum-card-actions-size: var(--mod-card-actions-size, var(--spectrum-card-selection-background-size));
5354
--spectrum-card-actions-border-radius: var(--mod-card-actions-border-radius, var(--spectrum-corner-radius-100));
5455

55-
/* TODO update to --spectrum-card-selection-background-color token once an RGB stripped value is available */
56-
--spectrum-card-actions-background-color-rgb: var(--mod-card-actions-background-color-rgb, var(--spectrum-gray-100-rgb));
57-
--spectrum-card-actions-background-color-opacity: var(--mod-card-actions-background-color-opacity, var(--spectrum-card-selection-background-color-opacity));
5856
--spectrum-card-actions-drop-shadow-color: var(--mod-card-actions-drop-shadow-color, var(--spectrum-drop-shadow-color));
5957
--spectrum-card-actions-drop-shadow-x: var(--mod-card-actions-drop-shadow-x, var(--spectrum-drop-shadow-x));
6058
--spectrum-card-actions-drop-shadow-y: var(--mod-card-actions-drop-shadow-y, var(--spectrum-drop-shadow-y));
@@ -73,11 +71,6 @@
7371
--spectrum-card-horizontal-body-padding: var(--mod-card-horizontal-body-padding, var(--spectrum-spacing-300));
7472
--spectrum-card-horizontal-preview-padding: var(--mod-card-horizontal-preview-padding, var(--spectrum-spacing-200));
7573

76-
&.spectrum-Card--quiet {
77-
--mod-card-minimum-width: var(--mod-card-minimum-width-quiet);
78-
--mod-card-content-margin-top: var(--mod-card-content-margin-top-quiet, var(--spectrum-spacing-100));
79-
}
80-
8174
&.spectrum-Card--gallery {
8275
--spectrum-card-content-margin-top: var(--spectrum-spacing-100);
8376
}
@@ -93,7 +86,7 @@
9386

9487
border: var(--spectrum-card-border-width) solid transparent;
9588
border-radius: var(--spectrum-card-corner-radius);
96-
border-color: var(--mod-card-border-color, var(--spectrum-card-border-color));
89+
border-color: var(--spectrum-card-border-color);
9790

9891
background-color: var(--spectrum-card-background-color);
9992

@@ -143,11 +136,16 @@
143136
}
144137

145138
&:hover {
146-
--mod-card-border-color: var(--mod-card-border-color-hover, var(--spectrum-card-border-color-hover));
139+
--mod-card-border-color: var(--spectrum-card-border-color-hover);
147140
}
148141

149-
&.is-selected::before {
150-
background-color: rgba(var(--mod-card-selected-background-color-rgb, var(--spectrum-card-selected-background-color-rgb)), var(--spectrum-card-selected-background-opacity));
142+
&.is-selected {
143+
--mod-card-border-color: var(--spectrum-card-border-color-selected);
144+
145+
&::before {
146+
/* @deprecated --mod-card-selected-background-color-rgb. Use --mod-card-background-color-selected instead. */
147+
background-color: var(--mod-card-background-color-selected, var(--spectrum-card-selection-background-color));
148+
}
151149
}
152150

153151
&.is-drop-target {
@@ -177,7 +175,7 @@
177175
inline-size: var(--spectrum-card-actions-size);
178176
block-size: var(--spectrum-card-actions-size);
179177
border-radius: var(--spectrum-card-actions-border-radius);
180-
background-color: rgba(var(--spectrum-card-actions-background-color-rgb), var(--spectrum-card-actions-background-color-opacity));
178+
background-color: var(--spectrum-card-selection-background-color);
181179

182180
inset-inline-start: calc(var(--spectrum-card-actions-spacing) - var(--spectrum-card-border-width));
183181
inset-block-start: calc(var(--spectrum-card-actions-spacing) - var(--spectrum-card-border-width));
@@ -218,8 +216,8 @@
218216
background-size: cover;
219217
background-position: center center;
220218

221-
background-color: var(--mod-card-preview-background-color, var(--spectrum-card-preview-background-color));
222-
border-block-end-color: var(--mod-card-border-color, var(--spectrum-card-border-color));
219+
background-color: var(--spectrum-card-preview-background-color);
220+
border-block-end-color: var(--spectrum-card-border-color);
223221
}
224222

225223
.spectrum-Card .spectrum-Divider {
@@ -290,7 +288,7 @@
290288

291289
color: var(--spectrum-card-body-font-color);
292290
line-height: var(--spectrum-card-body-line-height);
293-
border-block-start: var(--spectrum-card-border-width) solid var(--mod-card-divider-color, var(--spectrum-card-divider-color));
291+
border-block-start: var(--spectrum-card-border-width) solid var(--spectrum-card-divider-color);
294292
}
295293

296294
.spectrum-Card-header {
@@ -303,30 +301,6 @@
303301
z-index: 1;
304302
}
305303

306-
.spectrum-Card--quiet {
307-
.spectrum-Card-preview {
308-
border: var(--spectrum-card-focus-indicator-width) solid transparent;
309-
}
310-
311-
&:focus,
312-
&.is-focused {
313-
/* Quiet cards only have the focus indicator around the preview */
314-
&::after {
315-
border-width: 0;
316-
}
317-
318-
.spectrum-Card-preview::after {
319-
border-color: var(--spectrum-card-focus-indicator-color);
320-
}
321-
}
322-
323-
&.is-selected .spectrum-Card-preview {
324-
border: var(--spectrum-card-preview-border-width-selected) solid;
325-
border-color: var(--spectrum-card-border-color);
326-
}
327-
}
328-
329-
.spectrum-Card--quiet,
330304
.spectrum-Card--gallery {
331305
--mod-card-border-color-hover: transparent;
332306

@@ -342,7 +316,7 @@
342316

343317
.spectrum-Card-preview {
344318
border-radius: var(--spectrum-card-corner-radius);
345-
background-color: var(--mod-card-preview-background-color, var(--mod-card-background-color, var(--spectrum-card-preview-background-color)));
319+
background-color: var(--spectrum-card-preview-background-color);
346320
min-block-size: var(--mod-card-preview-minimum-height, var(--spectrum-card-preview-minimum-height));
347321
inline-size: 100%;
348322
flex: 1;
@@ -384,7 +358,7 @@
384358
}
385359

386360
&:hover .spectrum-Card-preview {
387-
background-color: var(--mod-card-preview-background-color-hover, var(--mod-card-background-color-hover, var(--spectrum-card-preview-background-color-hover)));
361+
background-color: var(--spectrum-card-preview-background-color-hover);
388362
}
389363

390364
&.is-drop-target {
@@ -394,7 +368,7 @@
394368

395369
.spectrum-Card-preview {
396370
transition: none;
397-
background-color: var(--mod-card-preview-background-color, var(--mod-card-background-color, var(--spectrum-card-preview-background-color)));
371+
background-color: var(--spectrum-card-preview-background-color);
398372
}
399373

400374
.spectrum-Card-preview::before {
@@ -422,7 +396,7 @@
422396
flex-direction: row;
423397

424398
&:hover .spectrum-Card-preview {
425-
border-color: var(--mod-card-border-color-hover, var(--spectrum-card-border-color-hover));
399+
--mod-card-border-color: var(--spectrum-card-border-color-hover);
426400
}
427401

428402
.spectrum-Card-preview {
@@ -438,8 +412,8 @@
438412
border-end-end-radius: 0;
439413

440414
padding: var(--spectrum-card-horizontal-preview-padding);
441-
background-color: var(--mod-card-preview-background-color, var(--spectrum-card-preview-background-color));
442-
border-color: var(--mod-card-border-color, var(--spectrum-card-border-color));
415+
background-color: var(--spectrum-card-preview-background-color);
416+
border-color: var(--spectrum-card-border-color);
443417
}
444418

445419
.spectrum-Card-header,

0 commit comments

Comments
 (0)