From 098fb9b708923f5600c0a6a5a7e4c73f189871cf Mon Sep 17 00:00:00 2001 From: Rahul Kumar Singh Date: Tue, 23 Sep 2025 14:31:57 +0530 Subject: [PATCH 1/7] fix: disable caching for forms content scraper --- src/forms-opportunities/handler.js | 2 +- test/fixtures/forms/expectedformsendtoscraperdata.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/forms-opportunities/handler.js b/src/forms-opportunities/handler.js index c2a026e45..7f72b4d9f 100644 --- a/src/forms-opportunities/handler.js +++ b/src/forms-opportunities/handler.js @@ -142,7 +142,7 @@ export async function runAuditAndSendUrlsForScrapingStep(context) { const result = { processingType: 'form', - allowCache: true, + allowCache: false, jobId: site.getId(), urls: urlsData, siteId: site.getId(), diff --git a/test/fixtures/forms/expectedformsendtoscraperdata.json b/test/fixtures/forms/expectedformsendtoscraperdata.json index 0f097a1b9..0672bc32e 100644 --- a/test/fixtures/forms/expectedformsendtoscraperdata.json +++ b/test/fixtures/forms/expectedformsendtoscraperdata.json @@ -149,7 +149,7 @@ "interval": 15 } }, - "allowCache": true, + "allowCache": false, "fullAuditRef": "www.example.com", "processingType": "form", "jobId": "test-site-id", From 187478ec29ca6688eec3a9cf09ceedbd64eb4587 Mon Sep 17 00:00:00 2001 From: Rahul Kumar Singh Date: Tue, 23 Sep 2025 15:14:14 +0530 Subject: [PATCH 2/7] fix: disable caching for forms content scraper --- src/forms-opportunities/handler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/forms-opportunities/handler.js b/src/forms-opportunities/handler.js index 7f72b4d9f..2194229a5 100644 --- a/src/forms-opportunities/handler.js +++ b/src/forms-opportunities/handler.js @@ -220,7 +220,7 @@ export async function processOpportunityStep(context) { await createLowViewsOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createLowConversionOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createAccessibilityOpportunity(latestAudit, context); - log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity identified`); + log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity1 identified`); return { status: 'complete', }; From f7cf55b2d8049a365f7ddbc913472b4089d3640b Mon Sep 17 00:00:00 2001 From: Rahul Kumar Singh Date: Tue, 23 Sep 2025 18:37:01 +0530 Subject: [PATCH 3/7] fix: disable caching for forms content scraper --- src/forms-opportunities/handler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/forms-opportunities/handler.js b/src/forms-opportunities/handler.js index 2194229a5..32b5d063a 100644 --- a/src/forms-opportunities/handler.js +++ b/src/forms-opportunities/handler.js @@ -220,7 +220,7 @@ export async function processOpportunityStep(context) { await createLowViewsOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createLowConversionOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createAccessibilityOpportunity(latestAudit, context); - log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity1 identified`); + log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity2 identified`); return { status: 'complete', }; From defa3223a80f7de87af828ff084e8739635eb056 Mon Sep 17 00:00:00 2001 From: Rahul Kumar Singh Date: Tue, 23 Sep 2025 19:39:13 +0530 Subject: [PATCH 4/7] fix: disable caching for forms content scraper --- src/forms-opportunities/handler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/forms-opportunities/handler.js b/src/forms-opportunities/handler.js index 32b5d063a..506174219 100644 --- a/src/forms-opportunities/handler.js +++ b/src/forms-opportunities/handler.js @@ -220,7 +220,7 @@ export async function processOpportunityStep(context) { await createLowViewsOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createLowConversionOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createAccessibilityOpportunity(latestAudit, context); - log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity2 identified`); + log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity3 identified`); return { status: 'complete', }; From 2a0899e96a63c98803b51be218fd3ba0527f3a55 Mon Sep 17 00:00:00 2001 From: Rahul Kumar Singh Date: Tue, 23 Sep 2025 20:15:59 +0530 Subject: [PATCH 5/7] fix: disable caching for forms content scraper --- src/forms-opportunities/handler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/forms-opportunities/handler.js b/src/forms-opportunities/handler.js index 506174219..c90be23c2 100644 --- a/src/forms-opportunities/handler.js +++ b/src/forms-opportunities/handler.js @@ -220,7 +220,7 @@ export async function processOpportunityStep(context) { await createLowViewsOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createLowConversionOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createAccessibilityOpportunity(latestAudit, context); - log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity3 identified`); + log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity4 identified`); return { status: 'complete', }; From 9c83ccea77989c25eebe504fc47389e4b5453d6c Mon Sep 17 00:00:00 2001 From: Rahul Kumar Singh Date: Wed, 24 Sep 2025 17:50:14 +0530 Subject: [PATCH 6/7] fix: disable caching for forms content scraper --- src/forms-opportunities/handler.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/forms-opportunities/handler.js b/src/forms-opportunities/handler.js index c90be23c2..c7cfe4849 100644 --- a/src/forms-opportunities/handler.js +++ b/src/forms-opportunities/handler.js @@ -229,6 +229,7 @@ export async function processOpportunityStep(context) { export default new AuditBuilder() .withUrlResolver(wwwUrlResolver) .addStep('runAuditAndSendUrlsForScraping', runAuditAndSendUrlsForScrapingStep, AUDIT_STEP_DESTINATIONS.CONTENT_SCRAPER) - .addStep('sendA11yUrlsForScrapingStep', sendA11yUrlsForScrapingStep, AUDIT_STEP_DESTINATIONS.CONTENT_SCRAPER) + // eslint-disable-next-line max-len + // .addStep('sendA11yUrlsForScrapingStep', sendA11yUrlsForScrapingStep, AUDIT_STEP_DESTINATIONS.CONTENT_SCRAPER) .addStep('processOpportunity', processOpportunityStep) .build(); From 85f500790e0e9d22e36a9ab8e32e1df33c848e28 Mon Sep 17 00:00:00 2001 From: Rahul Kumar Singh Date: Wed, 24 Sep 2025 18:49:17 +0530 Subject: [PATCH 7/7] fix: disable caching for forms content scraper --- src/forms-opportunities/handler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/forms-opportunities/handler.js b/src/forms-opportunities/handler.js index c7cfe4849..85313e65d 100644 --- a/src/forms-opportunities/handler.js +++ b/src/forms-opportunities/handler.js @@ -220,7 +220,7 @@ export async function processOpportunityStep(context) { await createLowViewsOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createLowConversionOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms); await createAccessibilityOpportunity(latestAudit, context); - log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity4 identified`); + log.info(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity5 identified`); return { status: 'complete', };