Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Autocomplete 'tab' key forwarding #7724

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

snowystinger
Copy link
Member

Closes #7619

First bug of #7619 (comment)

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 5, 2025

@rspbot
Copy link

rspbot commented Feb 5, 2025

@rspbot
Copy link

rspbot commented Feb 7, 2025

@rspbot
Copy link

rspbot commented Feb 7, 2025

## API Changes

@react-aria/dnd

/@react-aria/dnd:ClipboardProps

 ClipboardProps {
-  getItems?: ({
-    type: 'cut' | 'copy'
-}) => Array<DragItem>
+  getItems?: () => Array<DragItem>
   isDisabled?: boolean
   onCopy?: () => void
   onCut?: () => void
   onPaste?: (Array<DropItem>) => void

@react-aria/utils

/@react-aria/utils:createShadowTreeWalker

-createShadowTreeWalker {
-  doc: Document
-  root: Node
-  whatToShow?: number
-  filter?: NodeFilter | null
-  returnVal: undefined
-}

/@react-aria/utils:ShadowTreeWalker

-ShadowTreeWalker {
-  constructor: (Document, Node, number, NodeFilter | null) => void
-  currentNode: Node
-  doc: Document
-  filter: NodeFilter | null
-  firstChild: () => Node | null
-  lastChild: () => Node | null
-  nextNode: () => Node | null
-  previousNode: () => Node | null
-  root: Node
-  whatToShow: number
-}

/@react-aria/utils:getActiveElement

-getActiveElement {
-  doc: Document
-  returnVal: undefined
-}

/@react-aria/utils:getEventTarget

-getEventTarget {
-  event: any
-  returnVal: undefined
-}

/@react-aria/utils:nodeContains

-nodeContains {
-  node: Node | null | undefined
-  otherNode: Node | null | undefined
-  returnVal: undefined
-}

/@react-aria/utils:isShadowRoot

-isShadowRoot {
-  node: Node | null
-  returnVal: undefined
-}

@react-stately/flags

/@react-stately/flags:enableShadowDOM

-enableShadowDOM {
-  returnVal: undefined
-}

/@react-stately/flags:shadowDOM

-shadowDOM {
-  returnVal: undefined
-}

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully this doesn't cause conflicts with Daniel's PR... but I guess we can merge it separately 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAC: Autocomplete in Popover focus issues
3 participants