Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix custom selectors in version 2 #82

Open
janein opened this issue Jun 14, 2016 · 6 comments
Open

fix custom selectors in version 2 #82

janein opened this issue Jun 14, 2016 · 6 comments

Comments

@janein
Copy link

janein commented Jun 14, 2016

Hi,

would it be possible to make it compatible with jQuery 3.0?

@redmunds
Copy link
Contributor

@janein Thanks for head's up on jQuery 3.0. I don't know of any reason why it wouldn't work, but also not sure of when I'll have time to get to it.

@redmunds
Copy link
Contributor

@janein I have a proposed fix in PR #83 . Please try it out if you have the time.

@janein
Copy link
Author

janein commented Jun 30, 2016

@redmunds thanks. I tried it but it throws an Cannot read property 'className' of undefined on the this[0].className on line 285 on init and on window resize.
But I don't know if it's not a problem with my implementation as it doesn't throw this error everytime (sometime it passes by just fine).

@redmunds
Copy link
Contributor

@janein Thanks for testing -- that's a great catch! Code should make sure that property exists before de-referencing it.

@redmunds
Copy link
Contributor

redmunds commented Jul 3, 2016

Fixed in #87

@redmunds redmunds closed this as completed Jul 3, 2016
@redmunds
Copy link
Contributor

redmunds commented Jul 3, 2016

Re-opening. Leaving this open to remind me to fix custom selectors in version 2.

@redmunds redmunds reopened this Jul 3, 2016
@redmunds redmunds changed the title compatibility to jQuery 3.0 fix custom selectors in version 2 Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants