Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove project based manifest and configure dispatcher for product based PWA support #238

Closed
wants to merge 4 commits into from
Closed

Remove project based manifest and configure dispatcher for product based PWA support #238

wants to merge 4 commits into from

Conversation

keepthebyte
Copy link
Collaborator

@keepthebyte keepthebyte commented Apr 29, 2021 •
edited
Loading

To fix #237

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@godanny86
Copy link
Contributor

@keepthebyte this will remove the manifest, but doesn't add the productized PWA feature. Do we want to put all the changes in the same PR?

@davidjgonzalez davidjgonzalez added the More Info Needed More information is needed to troubleshot label Aug 5, 2021
@keepthebyte
Copy link
Collaborator Author

Will do a fresh PR based on latest code and review and add PWA feature as provided in the product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keepthebyte keepthebyte

Labels
More Info Needed More information is needed to troubleshot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove PWA specific code from project, provided by product now
3 participants
@keepthebyte @godanny86 @davidjgonzalez