Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PWA specific code from project, provided by product now #237

Open
keepthebyte opened this issue Apr 28, 2021 · 0 comments
Open

Remove PWA specific code from project, provided by product now #237

keepthebyte opened this issue Apr 28, 2021 · 0 comments
Assignees
@keepthebyte
Labels
enhancement New feature or request

Comments

@keepthebyte
Copy link
Collaborator

keepthebyte commented Apr 28, 2021 •
edited
Loading

Expected Behaviour

The current WKND project has hard-coded manifest. Given that AEM now supports PWA configuration via Page Properties on sites build with Core Components - we should remove the hard-coded copy and replace it with properties.

Want to use the PWA settings in the Page Properties to make the site installable. This project has a manifest in

https://github.com/adobe/aem-guides-wknd/blob/3524a6695e27181c46c089dffc80e223c0e6759d/ui.apps/src/main/content/jcr_root/apps/wknd/components/page/customheaderlibs.html

that needs to be removed.

Actual Behaviour

Use Page Properties to make the site a PWA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keepthebyte keepthebyte

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove project based manifest and configure dispatcher for product based PWA support
2 participants
@davidjgonzalez @keepthebyte