Skip to content

Commit ef5335e

Browse files
authored
Merge pull request #1177 from adobe/devtomaster09-April
Devtomaster09 april
2 parents 9e45e75 + 1f19bd4 commit ef5335e

File tree

32 files changed

+82
-47
lines changed

32 files changed

+82
-47
lines changed
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<template data-sly-template.longDescription="${@ componentId, longDescription, bemBlock}">
2-
<div aria-live="polite">
3-
<div class="${bemBlock}__longdescription" id="${componentId}__longdescription" data-sly-test="${longDescription}">
2+
<div class="${bemBlock}__longdescription" id="${componentId}__longdescription" data-sly-test="${longDescription}" aria-live="polite">
43
${longDescription @context='html'}
54
</div>
6-
</div>
75
</template>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template data-sly-template.shortDescription="${@ componentId, shortDescriptionVisible, shortDescription, bemBlock}">
2-
<div class="${bemBlock}__shortdescription" id="${componentId}__shortdescription" data-sly-test="${shortDescriptionVisible && shortDescription}">
2+
<div class="${bemBlock}__shortdescription" id="${componentId}__shortdescription" aria-live="polite" data-sly-test="${shortDescriptionVisible && shortDescription}">
33
${shortDescription @context='html'}
44
</div>
55
</template>

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/checkbox/v1/checkbox/checkbox.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
id="${checkbox.id}_widget"
4242
title="${checkbox.tooltipVisible ? '' : checkbox.tooltipText}"
4343
name="${checkbox.name}"
44-
aria-describedby="${checkbox.id}__errormessage ${checkbox.id}__longdescription ${checkbox.id}__shortdescription"
4544
value="${checkbox.default[0]}"
4645
disabled="${!checkbox.enabled}" />
4746

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/checkboxgroup/v1/checkboxgroup/clientlibs/site/js/checkboxgroupview.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,12 @@
111111
}
112112
}
113113

114+
updateValidity(validity) {
115+
const valid = validity.valid ? validity.valid : false;
116+
let widgets = this.widget;
117+
widgets.forEach(widget => widget.setAttribute(FormView.Constants.ARIA_INVALID, !valid));
118+
}
119+
114120
updateValue(modelValue) {
115121
modelValue = [].concat(modelValue);
116122
let selectedWidgetValues = modelValue.map(String);

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/datepicker/v1/datepicker/datepicker.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
title="${datePicker.tooltipVisible ? '' : datePicker.tooltipText}"
4747
id="${widgetId}"
4848
placeholder="${datePicker.placeHolder}"
49-
aria-describedby="${datePicker.id}__errormessage ${datePicker.id}__longdescription ${datePicker.id}__shortdescription"
5049
min="${datePicker.minimumDate}"
5150
max="${datePicker.maximumDate}"/>
5251
<div data-sly-call="${shortDescription.shortDescription @componentId=datePicker.id, shortDescriptionVisible=datePicker.tooltipVisible, shortDescription=datePicker.tooltip, bemBlock='cmp-adaptiveform-datepicker'}" data-sly-unwrap>

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/dropdown/v1/dropdown/dropdown.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
data-cmp-data-layer="${dropdown.data.json}"
4444
disabled="${!dropdown.enabled || dropdown.readOnly}"
4545
required="${dropdown.required}"
46-
aria-describedby="${dropdown.id}__errormessage ${dropdown.id}__longdescription ${dropdown.id}__shortdescription"
4746
data-sly-attribute.multiple="${dropdown.isMultiSelect ? 'multiple' : ''}"
4847
aria-readonly="${dropdown.readOnly ? 'true' : ''}">
4948
<div data-sly-test.isPlaceHolderSet="${dropdown.placeHolder != null}" data-sly-unwrap></div>

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/emailinput/v1/emailinput/emailinput.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
autocomplete="${email.autoComplete}"
5151
minlength="${email.minLength}"
5252
maxlength="${email.maxLength}"
53-
aria-describedby="${email.id}__errormessage ${email.id}__longdescription ${email.id}__shortdescription"
5453
dir="auto"/>
5554
<div data-sly-call="${shortDescription.shortDescription @componentId=email.id, shortDescriptionVisible=email.tooltipVisible, shortDescription=email.tooltip, bemBlock='cmp-adaptiveform-emailinput'}" data-sly-unwrap>
5655
</div>

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/fileinput/v2/fileinput/fileinput.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
required="${file.required}"
5050
accept="${file.accept}"
5151
id="${file.id}_widget"
52-
aria-describedby="${file.id}__errormessage ${file.id}__longdescription ${file.id}__shortdescription"
5352
type="file"
5453
data-cmp-data-layer="${file.data.json}"
5554
/>

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/numberinput/v1/numberinput/numberinput.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
disabled="${!numberinput.enabled}"
5050
readonly="${numberinput.readOnly}"
5151
required="${numberinput.required}"
52-
aria-describedby="${numberinput.id}__errormessage ${numberinput.id}__longdescription ${numberinput.id}__shortdescription"
5352
placeholder="${numberinput.placeHolder}"
5453
dir="auto"/>
5554
<div data-sly-call="${shortDescription.shortDescription @componentId=numberinput.id, shortDescriptionVisible=numberinput.tooltipVisible, shortDescription=numberinput.tooltip, bemBlock='cmp-adaptiveform-numberinput'}" data-sly-unwrap>

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/radiobutton/v1/radiobutton/clientlibs/site/js/radiobuttonview.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,12 @@
122122
});
123123
}
124124

125+
updateValidity(validity) {
126+
const valid = validity.valid ? validity.valid : false;
127+
let widgets = this.widget;
128+
widgets.forEach(widget => widget.setAttribute(FormView.Constants.ARIA_INVALID, !valid));
129+
}
130+
125131
updateValue(modelValue) {
126132
this.widget.forEach(widget => {
127133
if (modelValue != null && widget.value != null && (modelValue.toString() == widget.value.toString())) {
@@ -158,6 +164,7 @@
158164
updateEnumNames(newEnumNames) {
159165
super.updateEnumNamesForRadioButtonAndCheckbox(newEnumNames, this.#createRadioOption)
160166
}
167+
161168
updateRequired(required, state) {
162169
if (this.widget) {
163170
this.element.toggleAttribute("required", required);

0 commit comments

Comments
 (0)