From a1cb24b77b49bbad5c28c7df78c72f7a894ed195 Mon Sep 17 00:00:00 2001 From: Sushil Kumar <88363275+kum-sushil@users.noreply.github.com> Date: Sat, 27 Apr 2024 21:44:26 +0530 Subject: [PATCH] AF-Password|PR Comments| Removed Constants from FormConstants to direct values on view --- .../v1/password/clientlibs/site/css/passwordview.css | 2 +- .../v1/password/clientlibs/site/js/passwordview.js | 6 +++--- ui.frontend/src/constants.js | 12 ------------ 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/css/passwordview.css b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/css/passwordview.css index 92944601bf..29293adc97 100644 --- a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/css/passwordview.css +++ b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/css/passwordview.css @@ -21,7 +21,7 @@ .cmp-adaptiveform-password__widget { } - textarea.cmp-adaptiveform-password__widget{ + .cmp-adaptiveform-password__widget{ } diff --git a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/js/passwordview.js b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/js/passwordview.js index 8551120ca8..966dd5f42b 100644 --- a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/js/passwordview.js +++ b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/js/passwordview.js @@ -91,10 +91,10 @@ const widget = this.getWidget(); if(widget.value){ const widget = this.getWidget(); - if (widget.type === FormView.Constants.HTML_INPUT_TYPE_PASSWORD) { - widget.type = FormView.Constants.HTML_INPUT_TYPE_TEXT; + if (widget.type === "password") { + widget.type = "text"; } else { - widget.type = FormView.Constants.HTML_INPUT_TYPE_PASSWORD; + widget.type = "password"; } } } diff --git a/ui.frontend/src/constants.js b/ui.frontend/src/constants.js index df78fbe96a..ce831f40be 100644 --- a/ui.frontend/src/constants.js +++ b/ui.frontend/src/constants.js @@ -366,17 +366,5 @@ export const Constants = { * @type {string} */ API_PATH_PREFIX : "/adobe/forms/af", - - /** - * Html input type text - * @type {string} - */ - HTML_INPUT_TYPE_TEXT : "text", - - /** - * Html input type password - * @type {string} - */ - HTML_INPUT_TYPE_PASSWORD : "password" };