[v13 rc.11] Storyboard get_products forces legacy-only wire

[bokelley]

Summary

@adcp/sdk@13.0.0-rc.11 still forces storyboard get_products calls onto the legacy-only creative wire for negotiated AdCP 3.1 runs. This hides the transitional dual format_ids + format_options response that the rc.11 DecisioningPlatform runtime now emits by default.

This is the remaining storyboard-runner reproduction from #2491; the rc.11 server-runtime and explicit legacy-client fixes otherwise supersede the downstream rc.10 workarounds.

Reproduction

In dist/lib/testing/storyboard/task-map.{js,mjs}:

const callParams = legacyMethodName ? withLegacyCreativeWireHint(params) : params;

For a 3.1 client, gradesLegacyCreativeWire() selects getProductsLegacy, so an otherwise ambiguous get_products request receives ext.adcp.creative_wire = "legacy".

Against the AdCP training agent's media_buy_seller/canonical_formats scenario, unpatched rc.11 fails the first product assertion:

Expected "image", got undefined

because the response contains only format_ids and omits the expected canonical format_options declaration.

Expected

Do not inject the legacy-only wire hint for storyboard get_products. Keep explicit legacy routing for the other creative lifecycle tasks:

const callParams = legacyMethodName && taskName !== "get_products"
  ? withLegacyCreativeWireHint(params)
  : params;

With that change, the canonical-formats scenario passes 15/15 steps, and both the current 3.1 matrix and released 3.0.22 compatibility matrix pass across all seven tenants.

Downstream

adcontextprotocol/adcp#6307 carries an exact-version-gated CJS/ESM patch and removal ledger entry for rc.11.

[bokelley]

Triage

Classification: Bug
Bucket(s): conformance, library
Status: ready-to-implement

What the experts said:

• ad-tech-protocol-expert: Fix correctly decouples two independent acts — method selection (getProductsLegacy for wire grading) and hint injection (a response-mode directive that suppresses format_options). The one-liner as written will break task-map.test.ts:64, which asserts receivedParams contains the legacy wire hint for get_products; that assertion must change to {}. Also notes list_creatives shares the read-task characteristic and may need the same exclusion if a storyboard ever asserts canonical fields on it.
• code-reviewer: Agrees the fix is logically correct and that getProductsLegacy still provides meaningful grading without the hint. Recommends replacing the raw string check with a named set constant (e.g. LEGACY_WIRE_HINT_TASKS) so future LEGACY_CREATIVE_TASK_TO_METHOD additions don't silently inherit the hint.

My take: Both experts converge on the fix being correct, with two pre-landing requirements: updating the test expectation at task-map.test.ts:64 and extracting the exclusion into a named constant. No protocol or API surface changes — this is storyboard runner (test infrastructure) only.

Implementation brief:

• src/lib/testing/storyboard/task-map.ts line 198 — change legacyMethodName ? withLegacyCreativeWireHint(params) : params to use a named LEGACY_WIRE_HINT_TASKS set (containing create_media_buy, update_media_buy, sync_creatives, list_creatives — excluding get_products) instead of the raw taskName !== "get_products" string guard
• src/lib/testing/storyboard/task-map.test.ts line 64 — update the assertion from { ext: { adcp: { creative_wire: 'legacy' } } } to {} for the get_products case; add a separate assertion that getProductsLegacy is still called (the method selection is unchanged)
• Changeset required (npm run changeset, patch) — src/lib/ change ships in the npm package
• Run npm run ci:quick before opening the PR

---

Triaged by Claude Code. Session: https://claude.ai/code/session_01VXgzFyAstSab5NK1sADJ6H

---

Generated by Claude Code