Fix eager doctype regex matching #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 21 21
Lines 3572 3572
=======================================
Hits 3546 3546
Misses 26 26 ☔ View full report in Codecov by Sentry. |
|
@UVMvmfee That's correct, thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug encountered in the wild: repair_faulty_html() tries to match malformed doctype tags assuming the doctype to be followed by a newline. If there actually is no newline then the regex matches too eager, and parts of the document are removed erroneously.
A reduced test case is
<!DOCTYPE html><html><head></head><body>Foo <br/> Bar</body></html>which would be reduced toBar</body></html>without the fix.This PR adds a reduced test case and tries to fix eagerness by keeping the regex in tag bounderies. pytest shows no regressions.