Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review input type for is_probably_readerable() function #749

Open
adbar opened this issue Nov 22, 2024 · 0 comments
Open

Review input type for is_probably_readerable() function #749

adbar opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@adbar
Copy link
Owner

adbar commented Nov 22, 2024

The options passed to this functions should be of the Extractor type and not Any or dict, the tests have to be rewritten accordingly:

def is_probably_readerable(html: HtmlElement, options: Optional[Extractor] = None) -> bool:
...
    if options:
        option_dict = {attr: getattr(options, attr, None) for attr in options.__slots__}
    else:
        option_dict = {}
@adbar adbar added the enhancement New feature or request label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant